From d7d83bae5090c174a27b8b3b5e3934761d025f81 Mon Sep 17 00:00:00 2001
From: Chinmay Kulkarni <ckulkarni@cribl.io>
Date: Wed, 3 Jan 2024 18:43:30 -0800
Subject: [PATCH 1/3] fail on stderr

---
 azure-pipelines.yml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index 980545c..473ca17 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -58,15 +58,19 @@ jobs:
   - script: choco install nasm -fy
     displayName: Install Windows Assembler (NASM)
     condition: contains(variables['Agent.JobName'], 'windows')
+    failOnStderr: true
   - script: npm ci
     displayName: Install dependencies
+    failOnStderr: true
   - script: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
     displayName: setup docker for multi platform
     condition: contains(variables['Agent.JobName'], 'linux')
+    failOnStderr: true
   ## linux builds
   - script: node js2bin.js --ci --container=true --pointer-compress=$(ptrcompress) --node=$(node) --size=6MB --size=4MB --upload --clean --arch=${ARCH}
     displayName: Build base node binaries linux
     condition: contains(variables['Agent.JobName'], 'linux')
+    failOnStderr: true
     env:
       GITHUB_TOKEN: $(PersonalGithubToken)
       ARCH: $(arch)
@@ -74,5 +78,6 @@ jobs:
   - script: node js2bin.js --ci --container=true --pointer-compress=$(ptrcompress) --node=$(node) --size=6MB --size=4MB --upload --clean
     displayName: Build base node binaries non-linux
     condition: not(contains(variables['Agent.JobName'], 'linux'))
+    failOnStderr: true
     env:
       GITHUB_TOKEN: $(PersonalGithubToken)

From 47f2695f4f4a88c08b34e2d3aa064ab8b0750f99 Mon Sep 17 00:00:00 2001
From: ckulkarni-cribl <106271079+ckulkarni-cribl@users.noreply.github.com>
Date: Thu, 4 Jan 2024 09:52:26 -0800
Subject: [PATCH 2/3] Update azure-pipelines.yml

docker writes to stderr if image not found and pulls again
---
 azure-pipelines.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index 473ca17..f99ac2f 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -65,7 +65,6 @@ jobs:
   - script: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
     displayName: setup docker for multi platform
     condition: contains(variables['Agent.JobName'], 'linux')
-    failOnStderr: true
   ## linux builds
   - script: node js2bin.js --ci --container=true --pointer-compress=$(ptrcompress) --node=$(node) --size=6MB --size=4MB --upload --clean --arch=${ARCH}
     displayName: Build base node binaries linux

From 861424ef103bdb9475e2de0bee507cd09316625a Mon Sep 17 00:00:00 2001
From: ckulkarni-cribl <106271079+ckulkarni-cribl@users.noreply.github.com>
Date: Fri, 5 Jan 2024 09:57:42 -0800
Subject: [PATCH 3/3] 1/ try continueOnError: false

---
 azure-pipelines.yml | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/azure-pipelines.yml b/azure-pipelines.yml
index f99ac2f..9c3698f 100644
--- a/azure-pipelines.yml
+++ b/azure-pipelines.yml
@@ -58,10 +58,10 @@ jobs:
   - script: choco install nasm -fy
     displayName: Install Windows Assembler (NASM)
     condition: contains(variables['Agent.JobName'], 'windows')
-    failOnStderr: true
+    continueOnError: false
   - script: npm ci
     displayName: Install dependencies
-    failOnStderr: true
+    continueOnError: false
   - script: docker run --rm --privileged multiarch/qemu-user-static --reset -p yes
     displayName: setup docker for multi platform
     condition: contains(variables['Agent.JobName'], 'linux')
@@ -69,7 +69,7 @@ jobs:
   - script: node js2bin.js --ci --container=true --pointer-compress=$(ptrcompress) --node=$(node) --size=6MB --size=4MB --upload --clean --arch=${ARCH}
     displayName: Build base node binaries linux
     condition: contains(variables['Agent.JobName'], 'linux')
-    failOnStderr: true
+    continueOnError: false
     env:
       GITHUB_TOKEN: $(PersonalGithubToken)
       ARCH: $(arch)
@@ -77,6 +77,6 @@ jobs:
   - script: node js2bin.js --ci --container=true --pointer-compress=$(ptrcompress) --node=$(node) --size=6MB --size=4MB --upload --clean
     displayName: Build base node binaries non-linux
     condition: not(contains(variables['Agent.JobName'], 'linux'))
-    failOnStderr: true
+    continueOnError: false
     env:
       GITHUB_TOKEN: $(PersonalGithubToken)