Skip to content

PHP Notices should result in failure  #2

@alexcreode

Description

@alexcreode

The json response to a command that has notices says 'success':true but should return a failure.

Here are the snapshot:filesystem:restore errors and response json

Notice: Undefined index: filename in csmt.phar/src/Creode/Csmt/Command/Snapshot/Filesystem/SnapshotRestoreCommand.php on line 34

Notice: Undefined index: parentdir in csmt.phar/src/Creode/Csmt/Command/Snapshot/Filesystem/SnapshotRestoreCommand.php on line 35
unzip: cannot find or open /tmp/projectname/, /tmp/projectname/.zip or /tmp/projectname/.ZIP.

Warning: Cannot modify header information - headers already sent by (output started at csmt.phar/src/Creode/Csmt/Command/Snapshot/Filesystem/SnapshotRestoreCommand.php:34) in csmt.phar/src/Creode/Csmt/Response/Formatter/Json.php on line 11
{"message":"Restored filesystem snapshots","success":true}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions