feat(hero, popular-tools): update links to point to external osmium tool#47
feat(hero, popular-tools): update links to point to external osmium tool#47creatorcluster merged 2 commits intocreatorcluster:mainfrom
Conversation
- Change Hero component CTA links from internal routes to external Osmium URL - Update PopularTools component to support external links and modify first tool entry - Replace "Music Copyright Checker" with "Osmium" tool pointing to external site - Add conditional rendering to handle both internal and external navigation
|
@Coder-soft is attempting to deploy a commit to the yamura3's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughBoth Hero and PopularTools components were refactored to support external navigation. Hero.tsx now uses anchor tags pointing to an external Osmium application URL, replacing internal routes. PopularTools.tsx adds conditional rendering logic to detect external URLs and render tool cards as anchor elements instead of internal Links. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR replaces internal route links in the Key changes:
Issues found:
Confidence Score: 3/5
|
| Filename | Overview |
|---|---|
| src/components/Hero.tsx | Two <Link> elements replaced with <a> tags pointing to the external Osmium URL; both new anchors are missing target="_blank" and rel="noopener noreferrer", which will navigate users away from the SPA on click. |
| src/components/PopularTools.tsx | First tool entry renamed to "Osmium" with an external URL; conditional rendering correctly distinguishes internal (Link) vs. external (a) navigation, but the external anchor is missing target="_blank" and rel="noopener noreferrer". |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[User clicks link] --> B{Is path external?}
B -- Yes --> C[render external anchor tag]
B -- No --> D[render React Router Link]
C --> E[Navigate to osmiumchecks.vercel.app]
D --> F[SPA client-side navigation]
Last reviewed commit: 4fc69f8
| <a | ||
| href="https://osmiumchecks.vercel.app/" | ||
| className="inline-flex items-center rounded-full border border-cow-purple/30 bg-cow-purple/10 px-4 py-1.5 text-sm font-medium text-cow-purple transition-colors hover:bg-cow-purple/20 font-geist" | ||
| > | ||
| <span className="mr-2 px-2 py-0.5 rounded-full bg-cow-purple text-white text-xs font-bold">NEW</span> | ||
| Creator Packs are here! <IconArrowRight className="ml-2 h-4 w-4" /> | ||
| </Link> | ||
| Osmium out <IconArrowRight className="ml-2 h-4 w-4" /> | ||
| </a> |
There was a problem hiding this comment.
Missing target="_blank" and rel="noopener noreferrer" on external links
All three external <a> tags added in this PR are missing target="_blank" and rel="noopener noreferrer". Without target="_blank", clicking any of these links will navigate the user away from the SPA entirely, which is almost certainly unintended. Without rel="noopener noreferrer", the opened external page gets access to window.opener and can perform a reverse-tabnabbing redirect on the originating page.
This same issue applies to:
src/components/Hero.tsxline 165 (announcement badge)src/components/Hero.tsxline 229 (Check Music Copyright CTA)src/components/PopularTools.tsxline 144 (Osmium tool card link)
| <a | |
| href="https://osmiumchecks.vercel.app/" | |
| className="inline-flex items-center rounded-full border border-cow-purple/30 bg-cow-purple/10 px-4 py-1.5 text-sm font-medium text-cow-purple transition-colors hover:bg-cow-purple/20 font-geist" | |
| > | |
| <span className="mr-2 px-2 py-0.5 rounded-full bg-cow-purple text-white text-xs font-bold">NEW</span> | |
| Creator Packs are here! <IconArrowRight className="ml-2 h-4 w-4" /> | |
| </Link> | |
| Osmium out <IconArrowRight className="ml-2 h-4 w-4" /> | |
| </a> | |
| <a | |
| href="https://osmiumchecks.vercel.app/" | |
| target="_blank" | |
| rel="noopener noreferrer" | |
| className="inline-flex items-center rounded-full border border-cow-purple/30 bg-cow-purple/10 px-4 py-1.5 text-sm font-medium text-cow-purple transition-colors hover:bg-cow-purple/20 font-geist" | |
| > |
Change Hero component CTA links from internal routes to external Osmium URL
Update PopularTools component to support external links and modify first tool entry
Replace "Music Copyright Checker" with "Osmium" tool pointing to external site
Add conditional rendering to handle both internal and external navigation
Summary by CodeRabbit