Skip to content

Commit f994cd0

Browse files
authored
Merge pull request #9 from craigpotter/add-php8.4-support
Feature | PHP 8.4 Support (Tests)
2 parents 982d184 + fe8059a commit f994cd0

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

.github/workflows/tests.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ jobs:
1818
fail-fast: true
1919
matrix:
2020
os: [ ubuntu-latest, windows-latest ]
21-
php: [ 8.1, 8.2 ]
21+
php: [ 8.1, 8.2, 8.3, 8.4 ]
2222
stability: [ prefer-lowest, prefer-stable ]
2323

2424
name: P${{ matrix.php }} - ${{ matrix.stability }} - ${{ matrix.os }}

src/Fca.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,9 @@
44

55
namespace CraigPotter\Fca;
66

7-
use Saloon\Http\Connector;
87
use Saloon\Http\Request;
98
use Saloon\Http\Response;
9+
use Saloon\Http\Connector;
1010
use Saloon\PaginationPlugin\Paginator;
1111
use CraigPotter\Fca\Requests\GetEndpoint;
1212
use CraigPotter\Fca\Resources\FirmResource;

src/Resources/FirmResource.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55
namespace CraigPotter\Fca\Resources;
66

7-
use Saloon\Http\Connector;
87
use Saloon\Http\Response;
8+
use Saloon\Http\Connector;
99
use Saloon\PaginationPlugin\PagedPaginator;
1010
use Saloon\Exceptions\Request\RequestException;
1111
use CraigPotter\Fca\Requests\Firm\GetFirmDetails;
@@ -30,7 +30,7 @@ public function exists(): bool
3030
try {
3131
$response = $this->connector->send(new GetFirmDetails($this->frn));
3232
} catch (RequestException $e) {
33-
if(str_contains($e->getMessage(), 'Firm not found')) {
33+
if (str_contains($e->getMessage(), 'Firm not found')) {
3434
return false;
3535
}
3636

tests/Feature/FirmResourceTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,8 @@
33
declare(strict_types=1);
44

55
use CraigPotter\Fca\Fca;
6-
use Saloon\Http\Faking\MockClient;
76
use Saloon\Http\PendingRequest;
7+
use Saloon\Http\Faking\MockClient;
88
use Saloon\Http\Faking\MockResponse;
99
use CraigPotter\Fca\DataObjects\Address;
1010
use CraigPotter\Fca\DataObjects\Individual;

0 commit comments

Comments
 (0)