-
-
Notifications
You must be signed in to change notification settings - Fork 96
Open
Labels
bugSomething isn't workingSomething isn't working
Description
Current Behavior
When a filter setup on a field with matching condition not equals and value <empty/no value>, when the datasource doesn't exist, the filter return true
Expected Behavior
When a filter setup on a field with matching condition not equals and value <empty/no value>, when the datasource doesn't exist, the filter should return false
Step to reproduce
-
Setup a OSC Server to receive message (ex: Protokol).
-
Prepare a Rundown with a string customfield (ex: test).
-
Create 2 events:
- In event 1, fill the customfield with the value
"MyField". - In event 2, make sure the customfield is empty
- In event 1, fill the customfield with the value
-
Ensure that
Enable automationsis set to true in theAutomation settings -
Create an automation:
- Where all filters need to pass.
- With a filter on the create customfield where is not equals to an
<empty/no value> - With an output of type
OSC:- Make sure fields
Target IPandTarget Portpoint to the OSC Server setup at point 1. - Put a valid value in fields
Address - Put the customfield in the field
Arguments(ex:{{eventNow.custom.test}})
- Make sure fields
-
Play event 1 and notice on your OSC Server that:
- The automation have triggered
- The argument value is
"MyField"
-
Play event 2 and notice on you OSC Server that:
- The automation have triggered
- The argument value is
"{{eventNow.custom.test}}"
Unit test Suggestion
// apps\server\src\api-data\automation\__tests__\automation.service.test.ts
it('should check if a value does exist', () => {
const mockStore = makeRuntimeStateData({ eventNow: null });
expect(
testConditions([{ field: 'eventNow.title', operator: 'not_equals', value: '' }], 'all', mockStore),
).toBe(false);
});Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't working