From 607963fe9d9068965261eabb8b818051acb8c936 Mon Sep 17 00:00:00 2001 From: aehnh Date: Thu, 20 Mar 2025 14:05:52 +0100 Subject: [PATCH 1/3] change dummy emails --- .../scenarios/corbado-auth-general/login-init-email.spec.ts | 2 +- packages/tests-e2e/src/connect/scenarios/login.spec.ts | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/login-init-email.spec.ts b/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/login-init-email.spec.ts index 5657c948e..5a74ba044 100644 --- a/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/login-init-email.spec.ts +++ b/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/login-init-email.spec.ts @@ -43,7 +43,7 @@ test.describe('login-init', () => { test('bad user input: non-existing email', async ({ model }) => { await model.load(projectId, true, 'login-init'); - await model.loginInit.fillEmailUsername('user-does-not-exist@corbado.com'); + await model.loginInit.fillEmailUsername('integration-test+notexist@corbado.com'); await model.loginInit.submitPrimary(); await model.loginInit.expectTextError("Couldn't find your account."); }); diff --git a/packages/tests-e2e/src/connect/scenarios/login.spec.ts b/packages/tests-e2e/src/connect/scenarios/login.spec.ts index a8eada8c4..6d647c4a0 100644 --- a/packages/tests-e2e/src/connect/scenarios/login.spec.ts +++ b/packages/tests-e2e/src/connect/scenarios/login.spec.ts @@ -158,7 +158,7 @@ test.describe('login component (without user)', () => { await model.loadLogin(); await model.expectScreen(ScreenNames.InitLogin); - await model.login.submitEmail('unknown-email@corbado.com', false); + await model.login.submitEmail('integration-test+unknown@corbado.com', false); await model.expectError(ErrorTexts.UnknownEmail); }); @@ -167,7 +167,7 @@ test.describe('login component (without user)', () => { await model.loadLogin(); // It seems that the InitLogin page is now cached so that email needs to be submitted before reaching the InitLoginFallback screen. - await model.login.submitEmail('dummy-email@corbado.com', false); + await model.login.submitEmail('integration-test+dummy@corbado.com', false); await model.expectScreen(ScreenNames.InitLoginFallback); }); From 66b59267e323c23c57a71e685cad8d1a8c09a295 Mon Sep 17 00:00:00 2001 From: aehnh Date: Thu, 20 Mar 2025 14:26:13 +0100 Subject: [PATCH 2/3] skip social test --- .../src/complete/scenarios/corbado-auth-general/socials.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts b/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts index f4b1dbe19..75f4fb3fd 100644 --- a/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts +++ b/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts @@ -68,7 +68,7 @@ test.describe('social logins', () => { ); }); - test('signup with socials should be possible (account does not exist)', async ({ model }) => { + test.skip('signup with socials should be possible (account does not exist)', async ({ model }) => { await model.load(projectId, true, 'signup-init'); const email = process.env.PLAYWRIGHT_GOOGLE_EMAIL ?? ''; From dfe7a2080baf0a706f50e54df9bd0f4c1ffb28ab Mon Sep 17 00:00:00 2001 From: aehnh Date: Thu, 20 Mar 2025 14:32:46 +0100 Subject: [PATCH 3/3] add documentation link --- .../src/complete/scenarios/corbado-auth-general/socials.spec.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts b/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts index 75f4fb3fd..402ab93bd 100644 --- a/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts +++ b/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts @@ -68,6 +68,7 @@ test.describe('social logins', () => { ); }); + // Reason for skip: https://www.notion.so/Issues-related-to-email-and-social-login-in-tests-javascript-complete-1bceeb954aa280148c34d10aac8c2117 test.skip('signup with socials should be possible (account does not exist)', async ({ model }) => { await model.load(projectId, true, 'signup-init');