From f148f448680efd4f0c09f20b039a2e0b84f3a626 Mon Sep 17 00:00:00 2001 From: aehnh Date: Wed, 12 Mar 2025 09:55:14 +0100 Subject: [PATCH 1/2] skip social login test --- .../src/complete/scenarios/corbado-auth-general/socials.spec.ts | 2 +- packages/tests-e2e/src/connect/fixtures/BaseTest.ts | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts b/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts index f4b1dbe19..75f4fb3fd 100644 --- a/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts +++ b/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts @@ -68,7 +68,7 @@ test.describe('social logins', () => { ); }); - test('signup with socials should be possible (account does not exist)', async ({ model }) => { + test.skip('signup with socials should be possible (account does not exist)', async ({ model }) => { await model.load(projectId, true, 'signup-init'); const email = process.env.PLAYWRIGHT_GOOGLE_EMAIL ?? ''; diff --git a/packages/tests-e2e/src/connect/fixtures/BaseTest.ts b/packages/tests-e2e/src/connect/fixtures/BaseTest.ts index bc0688907..7d1ad37e6 100644 --- a/packages/tests-e2e/src/connect/fixtures/BaseTest.ts +++ b/packages/tests-e2e/src/connect/fixtures/BaseTest.ts @@ -2,8 +2,8 @@ import { test as base } from '@playwright/test'; import { BaseModel } from '../models/BaseModel'; import { CDPSessionManager } from '../utils/CDPSessionManager'; -import { VirtualAuthenticator } from '../utils/VirtualAuthenticator'; import { NetworkRequestBlocker } from '../utils/NetworkRequestBlocker'; +import { VirtualAuthenticator } from '../utils/VirtualAuthenticator'; export const test = base.extend<{ model: BaseModel }>({ model: async ({ page }, use) => { From 2cc686f9caff753b37db993f5976c5cc447f836a Mon Sep 17 00:00:00 2001 From: aehnh Date: Tue, 18 Mar 2025 14:46:04 +0100 Subject: [PATCH 2/2] remove oauth consent screens from google social login --- .../corbado-auth-general/socials.spec.ts | 2 +- .../src/complete/utils/externalauth.ts | 24 +++++++++---------- 2 files changed, 13 insertions(+), 13 deletions(-) diff --git a/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts b/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts index 75f4fb3fd..f4b1dbe19 100644 --- a/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts +++ b/packages/tests-e2e/src/complete/scenarios/corbado-auth-general/socials.spec.ts @@ -68,7 +68,7 @@ test.describe('social logins', () => { ); }); - test.skip('signup with socials should be possible (account does not exist)', async ({ model }) => { + test('signup with socials should be possible (account does not exist)', async ({ model }) => { await model.load(projectId, true, 'signup-init'); const email = process.env.PLAYWRIGHT_GOOGLE_EMAIL ?? ''; diff --git a/packages/tests-e2e/src/complete/utils/externalauth.ts b/packages/tests-e2e/src/complete/utils/externalauth.ts index bcdd10c99..298d9ed2f 100644 --- a/packages/tests-e2e/src/complete/utils/externalauth.ts +++ b/packages/tests-e2e/src/complete/utils/externalauth.ts @@ -95,20 +95,20 @@ export const socialLogin = async (page: Page, gmail: string, password: string, s await gmailPage.close(); await page.getByRole('button', { name: 'Continue with Google' }).click(); - await expect(page.getByRole('heading')).toHaveText('Choose an account'); - - await page.getByRole('button', { name: 'Corbado Systemtest' }).click(); - await expect(page.getByRole('heading')).toHaveText('corbado-staging.io wants to access your Google Account'); - - await page.getByRole('button', { name: 'Allow' }).click(); + // await expect(page.getByRole('heading')).toHaveText('Choose an account'); + // + // await page.getByRole('button', { name: 'Corbado Systemtest' }).click(); + // await expect(page.getByRole('heading')).toHaveText('corbado-staging.io wants to access your Google Account'); + // + // await page.getByRole('button', { name: 'Allow' }).click(); }; export const repeatSocialLogin = async (page: Page) => { await page.getByRole('button', { name: 'Continue with Google' }).click(); - await expect(page.getByRole('heading')).toHaveText('Choose an account'); - - await page.getByRole('button', { name: 'Corbado Systemtest' }).click(); - await expect(page.getByRole('heading')).toHaveText('corbado-staging.io wants to access your Google Account'); - - await page.getByRole('button', { name: 'Allow' }).click(); + // await expect(page.getByRole('heading')).toHaveText('Choose an account'); + // + // await page.getByRole('button', { name: 'Corbado Systemtest' }).click(); + // await expect(page.getByRole('heading')).toHaveText('corbado-staging.io wants to access your Google Account'); + // + // await page.getByRole('button', { name: 'Allow' }).click(); };