Skip to content

Bug: Hard-coded admin email in AdminMailer #43

@philipithomas

Description

@philipithomas

Description

In app/mailers/admin_mailer.rb:4-5:

default from: -> { ActionMailer::Base.email_address_with_name('admin@postcard.page', 'Postcard') },
        to: -> { 'mail@philipithomas.com' }

Admin notification recipient is hard-coded. This can't be configured per environment and exposes a personal email in source code.

Recommendation

Move the admin email to an environment variable.

Severity

Medium

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions