Skip to content

Performance: pluck().uniq instead of distinct.pluck in VisitsInLastDayJob #38

@philipithomas

Description

@philipithomas

Description

In app/jobs/visits_in_last_day_job.rb:8:

account_ids = Ahoy::Event.where("time > ?", 1.day.ago).pluck(:user_id).uniq

This loads all event user_ids into Ruby memory before deduplicating.

Recommendation

Use database-level deduplication:

account_ids = Ahoy::Event.where("time > ?", 1.day.ago).distinct.pluck(:user_id)

Severity

Medium

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions