From 47c36ca5e72bd9e614d8c02faf8b5a7390f23875 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Erik=20Sj=C3=B6lund?= Date: Wed, 11 Feb 2026 07:41:55 +0100 Subject: [PATCH] linux: do not use errno after success MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Suggestion by gemini-code-assist in https://github.com/containers/crun/pull/1993 was amended. Signed-off-by: Erik Sjölund --- src/libcrun/linux.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/libcrun/linux.c b/src/libcrun/linux.c index 1c27563994..bc87f08c7d 100644 --- a/src/libcrun/linux.c +++ b/src/libcrun/linux.c @@ -3695,10 +3695,11 @@ libcrun_set_sysctl (libcrun_container_t *container, libcrun_error_t *err) ret = TEMP_FAILURE_RETRY (write (fd, def->linux->sysctl->values[i], strlen (def->linux->sysctl->values[i]))); if (UNLIKELY (ret < 0)) { + int saved_errno = errno; cleanup_free char *reason = NULL; - reason = sysctl_error_reason (def->linux->sysctl->keys[i], namespaces_created, errno); - return crun_make_error (err, errno, "write to `/proc/sys/%s`%s%s%s", name, reason ? " (" : "", reason ?: "", reason ? ")" : ""); + reason = sysctl_error_reason (def->linux->sysctl->keys[i], namespaces_created, saved_errno); + return crun_make_error (err, saved_errno, "write to `/proc/sys/%s`%s%s%s", name, reason ? " (" : "", reason ?: "", reason ? ")" : ""); } } return 0;