From 389325f9fb6a38395b553cafcaed1b4a6915d8ff Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Mon, 8 Jul 2024 18:45:45 +0300 Subject: [PATCH 1/6] fix README.md --- audit/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audit/README.md b/audit/README.md index c77857e..4511e1b 100755 --- a/audit/README.md +++ b/audit/README.md @@ -177,7 +177,7 @@ Overall we consider the resulting contracts following the audit feedback period ### Disclaimer -Our team uses our current understanding of the best practises for Solidity and Smart Contracts. Development in Solidity and for Blockchain is an emergering area of software engineering which still has a lot of room to grow, hence our current understanding of best practise may not find all of the issues in this code and design. +Our team uses our current understanding of the best practices for Solidity and Smart Contracts. Development in Solidity and for Blockchain is an emerging area of software engineering which still has a lot of room to grow, hence our current understanding of best practise may not find all of the issues in this code and design. We have not analysed any of the assembly code generated by the Solidity compiler. We have not verified the deployment process and configurations of the contracts. We have only analysed the code outlined in the scope. We have not verified any of the claims made by any of the organisations behind this code. From 75993dfaf6d93f69302d82304c4d39acab7e2619 Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Mon, 8 Jul 2024 18:46:03 +0300 Subject: [PATCH 2/6] fix dynamic-analysis.md --- audit/dynamic-analysis.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audit/dynamic-analysis.md b/audit/dynamic-analysis.md index 10b3983..eea7059 100755 --- a/audit/dynamic-analysis.md +++ b/audit/dynamic-analysis.md @@ -14,7 +14,7 @@ Contract: Distribution Initialize ✓ Reserve should be less than total supply cap (67ms) - ✓ Distribution cap is a diffence between total supply cap and reserve (156ms) + ✓ Distribution cap is a difference between total supply cap and reserve (156ms) ✓ Token total supply should be 0 at the beginning of distribution (228ms) Contract: Distribution From 20973a42fd9e4705a968280a66b58cd06491508c Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Mon, 8 Jul 2024 18:46:33 +0300 Subject: [PATCH 3/6] fix gas-consumption-report.md --- audit/gas-consumption-report.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/audit/gas-consumption-report.md b/audit/gas-consumption-report.md index 72d9d87..434846b 100755 --- a/audit/gas-consumption-report.md +++ b/audit/gas-consumption-report.md @@ -16,7 +16,7 @@ performed by Blockchain Labs, February 27, 2018 Contract: Distribution Initialize ✓ Reserve should be less than total supply cap (584964 gas) - ✓ Distribution cap is a diffence between total supply cap and reserve (1877243 gas) + ✓ Distribution cap is a difference between total supply cap and reserve (1877243 gas) ✓ Token total supply should be 0 at the beginning of distribution (4121541 gas) Contract: Distribution @@ -103,4 +103,4 @@ performed by Blockchain Labs, February 27, 2018 ## Summary Upon finalization of the contracts to be used by **Mothership**, the contracts were assessed on the gas usage of each function to ensure there aren't any unforeseen issues with exceeding the block size GasLimit. -
\ No newline at end of file +
From c3fa1abfab541b879aa0842f1affca1e8dfc8932 Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Mon, 8 Jul 2024 18:47:01 +0300 Subject: [PATCH 4/6] fix static-analysis.md --- audit/static-analysis.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/audit/static-analysis.md b/audit/static-analysis.md index e373888..473a641 100755 --- a/audit/static-analysis.md +++ b/audit/static-analysis.md @@ -82,7 +82,7 @@ If the caller is the contract controller, the function simply forwards the call - When called by Controller - it should call `doTransfer()` in any case - When called by Token holder - - it should fail if the the sender didn't allow to transfer requested amount + - it should fail if the sender didn't allow to transfer requested amount - it should call `doTransfer()` if the transfer allowed From 0ae38024039ea22a936db9f6bd91e22b42db743e Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Mon, 8 Jul 2024 18:47:42 +0300 Subject: [PATCH 5/6] fix ERC20Token.sol --- contracts/interface/ERC20Token.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/interface/ERC20Token.sol b/contracts/interface/ERC20Token.sol index 4a01b80..871ec18 100644 --- a/contracts/interface/ERC20Token.sol +++ b/contracts/interface/ERC20Token.sol @@ -32,7 +32,7 @@ contract ERC20Token { /// @param _owner The address of the account owning tokens /// @param _spender The address of the account able to transfer the tokens - /// @return Amount of remaining tokens allowed to spent + /// @return Amount of remaining tokens allowed to be spent function allowance(address _owner, address _spender) public view returns (uint256 remaining); event Transfer(address indexed _from, address indexed _to, uint256 _value); From e5992de668546f15d7e9ad2c5ebd1f50fe5521fd Mon Sep 17 00:00:00 2001 From: Elias Rad <146735585+nnsW3@users.noreply.github.com> Date: Mon, 8 Jul 2024 18:48:00 +0300 Subject: [PATCH 6/6] fix MiniMeTokenI.sol --- contracts/interface/MiniMeTokenI.sol | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contracts/interface/MiniMeTokenI.sol b/contracts/interface/MiniMeTokenI.sol index ae9b267..49757a6 100644 --- a/contracts/interface/MiniMeTokenI.sol +++ b/contracts/interface/MiniMeTokenI.sol @@ -5,7 +5,7 @@ import "./Burnable.sol"; /// @dev MiniMeToken interface. Using this interface instead of whole contracts -/// will reduce contract sise and gas cost +/// will reduce contract size and gas cost contract MiniMeTokenI is ERC20Token, Burnable { string public name; //The Token's name: e.g. DigixDAO Tokens