-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Hello @confessore ,
May I make a suggestion for better semantics?
In your CoinbaseATClient class, there are properties
/// <summary>
/// <inheritdoc />
/// </summary>
public IAccountsService AccountsService { get; }
/// <summary>
/// <inheritdoc />
/// </summary>
public IFeesService FeesService { get; }
/// <summary>
/// <inheritdoc />
/// </summary>
public IOrdersService OrdersService { get; }
/// <summary>
/// <inheritdoc />
/// </summary>
public IProductsService ProductsService { get; }
I suggest they be named:
/// <summary>
/// <inheritdoc />
/// </summary>
public IAccountsService Accounts { get; }
/// <summary>
/// <inheritdoc />
/// </summary>
public IFeesService Fees { get; }
/// <summary>
/// <inheritdoc />
/// </summary>
public IOrdersService Orders { get; }
/// <summary>
/// <inheritdoc />
/// </summary>
public IProductsService Products { get; }
This naming style does seem to more closely resemble the convention for API clients.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestgood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed