Skip to content

Suggestion: Rename, e.g., AccountsService property of CoinbaseATClient to Accounts, etc. #3

@astrohart

Description

@astrohart

Hello @confessore ,

May I make a suggestion for better semantics?

In your CoinbaseATClient class, there are properties

        /// <summary>
        ///     <inheritdoc />
        /// </summary>
        public IAccountsService AccountsService { get; }

        /// <summary>
        ///     <inheritdoc />
        /// </summary>
        public IFeesService FeesService { get; }

        /// <summary>
        ///     <inheritdoc />
        /// </summary>
        public IOrdersService OrdersService { get; }

        /// <summary>
        ///     <inheritdoc />
        /// </summary>
        public IProductsService ProductsService { get; }

I suggest they be named:

        /// <summary>
        ///     <inheritdoc />
        /// </summary>
        public IAccountsService Accounts { get; }

        /// <summary>
        ///     <inheritdoc />
        /// </summary>
        public IFeesService Fees { get; }

        /// <summary>
        ///     <inheritdoc />
        /// </summary>
        public IOrdersService Orders { get; }

        /// <summary>
        ///     <inheritdoc />
        /// </summary>
        public IProductsService Products { get; }

This naming style does seem to more closely resemble the convention for API clients.

Metadata

Metadata

Assignees

Labels

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions