Should collective.shibboleth be working with Plone 5?

[ianzd]

I've only managed to get collective.shibboleth working with Plone 4. In Plone5, going to "Log in" gets me a browser modal that says "Error loading modal", and the attached error in instance.log

plone5-collective-shibboleth-error.txt

[davidjb]

I'm not currently using Plone 5 so haven't looked into how any components work with it. PR and fixes are most welcome!

[tisto]

Any update here? Anybody who tried to get c.shibboleth running with Plone 5?

@davidjb we could set up a Travis build for Plone 5 and check if build and tests work, what do you think?

[davidjb]

For sure; go right ahead. My focus is on other platforms than Plone at present but it would be good to ensure compatibility with Plone 5.

[tisto]

@davidjb seems we don't have a Travis setup for c.s yet: https://travis-ci.org/collective/collective.shibboleth

[davidjb]

It's not something I'd done previously, so please go right ahead. My focus is on other projects at the moment but if you need my input on something, let me know :)

[davidjb]

It's not something I'd done previously, so please go right ahead. My focus is on other projects at the moment but if you need my input on something, let me know :)

[tisto]

@davidjb I set up Travis for Plone 4.3, 5.0, and 5.1. I had to add a few missing test requirements and fix a wrong import on a test file. Though, we still have two test failures on the normal 4.3 tests:

https://travis-ci.org/collective/collective.shibboleth/jobs/439144358

Any idea where they come from?

[tisto]

@davidjb is it possible that those tests never actually passed? The test setup was using a collective.shibboleth.portlets package that does not exist. Anyways, I fixed the test setup and now all tests pass.

[davidjb]

Very possibly, @tisto. That package name sounds like it was prior to a refactoring that happened some time ago so I'd say yes, they probably never worked. Thanks for making all that work in that case!