From 6a64ae43e37825937ef876f294fc5b7610bf8b6b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ramirez=20Vargas=2C=20Jos=C3=A9=20Pablo?= Date: Wed, 17 Dec 2025 20:37:46 -0600 Subject: [PATCH 1/2] fix(Piece): Allow promises to CorePiece objects --- package-lock.json | 8 ++++---- package.json | 4 ++-- src/lib/Piece/Piece.svelte | 4 ++-- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index 6130534..45d0ba6 100644 --- a/package-lock.json +++ b/package-lock.json @@ -24,14 +24,14 @@ "vitest-browser-svelte": "^2.0.1" }, "peerDependencies": { - "@collagejs/core": "^0.1.0", + "@collagejs/core": "^0.1.2", "svelte": "^5.0.0" } }, "node_modules/@collagejs/core": { - "version": "0.1.0", - "resolved": "https://registry.npmjs.org/@collagejs/core/-/core-0.1.0.tgz", - "integrity": "sha512-QXsCAszPRkRcSn/dnOHdFaODAwxmthAeH2dtC9IXc31mSFXJ47oTcNrpDvuW9ChQlvvbzV+NCIjmj7d2FPX32A==", + "version": "0.1.2", + "resolved": "https://registry.npmjs.org/@collagejs/core/-/core-0.1.2.tgz", + "integrity": "sha512-W6YKZbXeLi+XCgu2mDssmCITQEOonwiJgm4C6+um0JuP58PYDO+UyO2uegr2OlMjsnQdx/nONPk9hmajIlV6mQ==", "license": "MIT", "peer": true }, diff --git a/package.json b/package.json index aa5adef..3ac344c 100644 --- a/package.json +++ b/package.json @@ -46,8 +46,8 @@ } }, "peerDependencies": { - "svelte": "^5.0.0", - "@collagejs/core": "^0.1.0" + "@collagejs/core": "^0.1.2", + "svelte": "^5.0.0" }, "devDependencies": { "@playwright/test": "^1.57.0", diff --git a/src/lib/Piece/Piece.svelte b/src/lib/Piece/Piece.svelte index e81ae91..c39f848 100644 --- a/src/lib/Piece/Piece.svelte +++ b/src/lib/Piece/Piece.svelte @@ -16,7 +16,7 @@ /** * The `CorePiece` instance to render. */ - piece: CorePiece; + piece: CorePiece | Promise>; /** * Optional HTML attributes to set on the container element that wraps the piece. */ @@ -40,7 +40,7 @@ export function piece< TProps extends Record = Record, >( - piece: CorePiece, + piece: CorePiece | Promise>, containerProps?: HTMLAttributes, ) { return { From a2b58d52153facd5a8844a952319865226849635 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ramirez=20Vargas=2C=20Jos=C3=A9=20Pablo?= Date: Wed, 17 Dec 2025 20:42:18 -0600 Subject: [PATCH 2/2] fix(cicd): Change test script for CI/CD --- .github/workflows/publish.yml | 2 +- .github/workflows/test.yml | 2 +- package.json | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/workflows/publish.yml b/.github/workflows/publish.yml index a7a9d37..fa2e6d5 100644 --- a/.github/workflows/publish.yml +++ b/.github/workflows/publish.yml @@ -24,7 +24,7 @@ jobs: with: node-version: 24 build-script: build - test-script: test + test-script: test:cicd npm-tag: ${{ inputs.npm-tag || 'latest' }} dry-run: ${{ inputs.dry-run || false }} secrets: inherit diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ca9dff9..705e339 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -14,5 +14,5 @@ jobs: with: node-version: 24 build-script: build - test-script: test + test-script: test:cicd build: false diff --git a/package.json b/package.json index 3ac344c..8983ccc 100644 --- a/package.json +++ b/package.json @@ -25,6 +25,7 @@ "check:watch": "svelte-kit sync && svelte-check --tsconfig ./tsconfig.json --watch", "test:unit": "vitest", "test": "npm run test:unit -- --run", + "test:cicd": "npx playwright install && npm run test", "test:e2e": "playwright test" }, "files": [