From 62bcf1bb87f1e668deeb23950c77d855d002c2d2 Mon Sep 17 00:00:00 2001 From: Greg Wang Date: Wed, 19 Feb 2025 14:06:54 -0800 Subject: [PATCH 1/2] Log shutdown progress for activity and workflow pollers --- CHANGELOG.md | 3 +++ lib/cadence/activity/poller.rb | 2 ++ lib/cadence/version.rb | 2 +- lib/cadence/workflow/poller.rb | 4 +++- 4 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 5daf573e..26579622 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,5 +1,8 @@ # Changelog +## 0.1.22 +- Log shutdown progress for activity and workflow pollers + ## 0.1.21 - Add workflow id and activity id to workflow and activity logs diff --git a/lib/cadence/activity/poller.rb b/lib/cadence/activity/poller.rb index dc8d9007..c22ca283 100644 --- a/lib/cadence/activity/poller.rb +++ b/lib/cadence/activity/poller.rb @@ -33,7 +33,9 @@ def stop def wait thread.join + Cadence.logger.info('Draining activity worker job queue') thread_pool.shutdown + Cadence.logger.info('Activity poller shutdown gracefully') end private diff --git a/lib/cadence/version.rb b/lib/cadence/version.rb index 1c254a5b..b90ed628 100644 --- a/lib/cadence/version.rb +++ b/lib/cadence/version.rb @@ -1,3 +1,3 @@ module Cadence - VERSION = '0.1.21'.freeze + VERSION = '0.1.22'.freeze end diff --git a/lib/cadence/workflow/poller.rb b/lib/cadence/workflow/poller.rb index 74a7faff..49bffa97 100644 --- a/lib/cadence/workflow/poller.rb +++ b/lib/cadence/workflow/poller.rb @@ -29,12 +29,14 @@ def start def stop @shutting_down = true - Cadence.logger.info('Shutting down a workflow poller') + Cadence.logger.info('Shutting down workflow poller') end def wait @thread.join + Cadence.logger.info('Draining workflow worker job queue') thread_pool.shutdown + Cadence.logger.info('Workflow poller shutdown gracefully') end private From 1544f2dfb2608de19e67558a3021f05f5dd3be58 Mon Sep 17 00:00:00 2001 From: Greg Wang Date: Wed, 19 Feb 2025 14:16:50 -0800 Subject: [PATCH 2/2] Bump version to v0.1.28 to sync up with the internal repo --- CHANGELOG.md | 5 ++++- lib/cadence/version.rb | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 26579622..de24d0a6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,7 +1,10 @@ # Changelog -## 0.1.22 +## 0.1.28 - Log shutdown progress for activity and workflow pollers +- Add WorkflowAlreadyCompletingError to the rbi file +- Validate that a workflow isn't completed before recording commands +- Ruby 3 compatibility ## 0.1.21 - Add workflow id and activity id to workflow and activity logs diff --git a/lib/cadence/version.rb b/lib/cadence/version.rb index b90ed628..98ccdd95 100644 --- a/lib/cadence/version.rb +++ b/lib/cadence/version.rb @@ -1,3 +1,3 @@ module Cadence - VERSION = '0.1.22'.freeze + VERSION = '0.1.28'.freeze end