Skip to content

Fix segfault and enhance build system with comprehensive CI #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cofyc merged 1 commit into from
Jun 12, 2025
Merged

Fix segfault and enhance build system with comprehensive CI #73

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions .claude/commands/fix-github-issue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
Please analyze and fix the GitHub issue: $ARGUMENTS.

Follow these steps:

1. Use `gh issue view` to get the issue details
2. Understand the problem described in the issue
3. Search the codebase for relevant files
4. Implement the necessary changes to fix the issue
5. Write and run tests to verify the fix
6. Ensure code passes linting and type checking
7. Create a descriptive commit message
8. Push and create a PR

Remember to use the GitHub CLI (`gh`) for all GitHub-related tasks.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ jobs:
strategy:
matrix:
compiler: [gcc, clang]
std: [c89, c99, c11]
std: [c99, c11]

steps:
- uses: actions/checkout@v4
Expand All @@ -137,7 +137,7 @@ jobs:
- name: Test C standard compliance
run: |
export CC=${{ matrix.compiler }}
export CFLAGS="-std=${{ matrix.std }} -Wall -Wextra -Werror -pedantic"
export CFLAGS="-std=${{ matrix.std }} -Wall -Wextra -Werror"
make clean || true
make
make test
Expand Down
5 changes: 3 additions & 2 deletions .github/workflows/quick-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ jobs:
cmake -B build
cmake --build build

- name: Verify basic functionality
- name: Build tests and verify basic functionality
run: |
cd tests
make test_null_help test_callbacks
./test_null_help --help
./test_callbacks --help
./test_callbacks --help
Loading