fix: closing file descriptors

nerg4l · nerg4l · commit fcbcc1cffc98 · 2025-04-25T13:50:32.000+02:00
diff --git a/cmd/mkc/internal/list/list.go b/cmd/mkc/internal/list/list.go
@@ -57,6 +57,7 @@ func run(flags *flag.FlagSet) {
 		fmt.Fprintf(os.Stderr, "Could not open input file: %s\n", args.Input)
 		os.Exit(1)
 	}
+	defer f.Close()
 
 	r := io.MultiReader(f) // remove seeking capability
 	s := matroska.NewScanner(r)
diff --git a/cmd/mkdev/ogg.go b/cmd/mkdev/ogg.go
@@ -12,6 +12,7 @@ func analyzeOggPackages(filename string) error {
 	if err != nil {
 		return err
 	}
+	defer f.Close()
 	d := ogg.NewDecoder(f)
 	streams, err := d.DecodeStreams()
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -57,6 +57,7 @@ func run(flags *flag.FlagSet) {`
`57`	`57`	`fmt.Fprintf(os.Stderr, "Could not open input file: %s\n", args.Input)`
`58`	`58`	`os.Exit(1)`
`59`	`59`	`}`
	`60`	`+ defer f.Close()`
`60`	`61`
`61`	`62`	`r := io.MultiReader(f) // remove seeking capability`
`62`	`63`	`s := matroska.NewScanner(r)`
Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@ func analyzeOggPackages(filename string) error {`
`12`	`12`	`if err != nil {`
`13`	`13`	`return err`
`14`	`14`	`}`
	`15`	`+ defer f.Close()`
`15`	`16`	`d := ogg.NewDecoder(f)`
`16`	`17`	`streams, err := d.DecodeStreams()`
`17`	`18`	`if err != nil {`