From 7e2aa7cf0adadcebbdf4e3c2c71fff76a283a8db Mon Sep 17 00:00:00 2001 From: Matous Jobanek Date: Tue, 25 Feb 2025 12:41:59 +0100 Subject: [PATCH 1/2] add request-received-time annotation key --- api/v1alpha1/usersignup_types.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/api/v1alpha1/usersignup_types.go b/api/v1alpha1/usersignup_types.go index e470d644..829f7481 100644 --- a/api/v1alpha1/usersignup_types.go +++ b/api/v1alpha1/usersignup_types.go @@ -43,6 +43,9 @@ const ( // UserSignupCaptchaAnnotatedAssessmentAnnotationKey is set if the last captcha assessment for the user was annotated as fraudulent or legitimate UserSignupCaptchaAnnotatedAssessmentAnnotationKey = LabelKeyPrefix + "captcha-annotated-assessment" + // UserSignupRequestReceivedTimeAnnotationKey is used for the timestamp when the request to create/reactivate UserSignup was received (stored in time.RFC3339 format) + UserSignupRequestReceivedTimeAnnotationKey = LabelKeyPrefix + "request-received-time" + // UserSignupUserEmailHashLabelKey is used for the usersignup email hash label key UserSignupUserEmailHashLabelKey = LabelKeyPrefix + "email-hash" // UserSignupUserPhoneHashLabelKey is used for the usersignup phone hash label key From 345bb54073d54d17f7cd7450b768974ad3df6c21 Mon Sep 17 00:00:00 2001 From: Matous Jobanek Date: Tue, 25 Feb 2025 13:18:19 +0100 Subject: [PATCH 2/2] comment --- api/v1alpha1/usersignup_types.go | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/api/v1alpha1/usersignup_types.go b/api/v1alpha1/usersignup_types.go index 829f7481..6d1c1d42 100644 --- a/api/v1alpha1/usersignup_types.go +++ b/api/v1alpha1/usersignup_types.go @@ -43,7 +43,8 @@ const ( // UserSignupCaptchaAnnotatedAssessmentAnnotationKey is set if the last captcha assessment for the user was annotated as fraudulent or legitimate UserSignupCaptchaAnnotatedAssessmentAnnotationKey = LabelKeyPrefix + "captcha-annotated-assessment" - // UserSignupRequestReceivedTimeAnnotationKey is used for the timestamp when the request to create/reactivate UserSignup was received (stored in time.RFC3339 format) + // UserSignupRequestReceivedTimeAnnotationKey is used for the timestamp when the request to create/reactivate UserSignup was received + // The time is stored in time.RFC3339 format, the reason is that the main purpose of the metric is to track the UX of the users, and milliseconds don't really matter in that case UserSignupRequestReceivedTimeAnnotationKey = LabelKeyPrefix + "request-received-time" // UserSignupUserEmailHashLabelKey is used for the usersignup email hash label key