Enable stylistic type checked

Author: EhabY

eslint.config.mjs

@@ -33,7 +33,7 @@ export default defineConfig(
 		files: ["**/*.ts"],
 		extends: [
 			...tseslint.configs.recommendedTypeChecked,
-			...tseslint.configs.stylistic,
+			...tseslint.configs.stylisticTypeChecked,
 			importXFlatConfigs.typescript,
 		],
 		languageOptions: {
@@ -74,6 +74,16 @@ export default defineConfig(
 				{ varsIgnorePattern: "^_" },
 			],
 			"@typescript-eslint/array-type": ["error", { default: "array-simple" }],
+			"@typescript-eslint/prefer-nullish-coalescing": [
+				"error",
+				// Allow || for strings where empty string should be treated as falsy
+				{ ignorePrimitives: { string: true } },
+			],
+			"@typescript-eslint/dot-notation": [
+				"error",
+				// Allow bracket notation for index signatures (e.g., Record<string, T>)
+				{ allowIndexSignaturePropertyAccess: true },
+			],
 
 			// Import rules
 			"import-x/order": [

src/api/api-helper.ts

@@ -18,9 +18,8 @@ export function errToStr(error: unknown, def = "No error message provided") {
 	} else if (isApiErrorResponse(error)) {
 		return error.message;
 	} else if (error instanceof ErrorEvent) {
-		return error.code
-			? `${error.code}: ${error.message || def}`
-			: error.message || def;
+		const message = error.message || def;
+		return error.code ? `${error.code}: ${message}` : message;
 	} else if (typeof error === "string" && error.trim().length > 0) {
 		return error;
 	}
@@ -46,7 +45,7 @@ export function extractAgents(
 	resources: readonly WorkspaceResource[],
 ): WorkspaceAgent[] {
 	return resources.reduce((acc, resource) => {
-		return acc.concat(resource.agents || []);
+		return acc.concat(resource.agents ?? []);
 	}, [] as WorkspaceAgent[]);
 }
 

src/api/coderApi.ts

@@ -501,7 +501,7 @@ function addLoggingInterceptors(client: AxiosInstance, logger: Logger) {
 
 			config.transformRequest = [
 				...wrapRequestTransform(
-					config.transformRequest || client.defaults.transformRequest || [],
+					config.transformRequest ?? client.defaults.transformRequest ?? [],
 					configWithMeta,
 				),
 				(data: unknown) => {
@@ -512,7 +512,7 @@ function addLoggingInterceptors(client: AxiosInstance, logger: Logger) {
 			];
 
 			config.transformResponse = wrapResponseTransform(
-				config.transformResponse || client.defaults.transformResponse || [],
+				config.transformResponse ?? client.defaults.transformResponse ?? [],
 				configWithMeta,
 			);
 

src/api/proxy.ts

@@ -1,7 +1,7 @@
 // This file is copied from proxy-from-env with added support to use something
 // other than environment variables.
 
-import { parse as parseUrl } from "url";
+import { parse as parseUrl } from "node:url";
 
 const DEFAULT_PORTS: Record<string, number> = {
 	ftp: 21,
@@ -34,7 +34,8 @@ export function getProxyForUrl(
 	// Stripping ports in this way instead of using parsedUrl.hostname to make
 	// sure that the brackets around IPv6 addresses are kept.
 	hostname = hostname.replace(/:\d*$/, "");
-	const port = (portRaw && parseInt(portRaw)) || DEFAULT_PORTS[proto] || 0;
+	const port =
+		(portRaw && Number.parseInt(portRaw)) || DEFAULT_PORTS[proto] || 0;
 	if (!shouldProxy(hostname, port, noProxy)) {
 		return ""; // Don't proxy URLs that match NO_PROXY.
 	}
@@ -45,7 +46,7 @@ export function getProxyForUrl(
 		getEnv(proto + "_proxy") ||
 		getEnv("npm_config_proxy") ||
 		getEnv("all_proxy");
-	if (proxy && proxy.indexOf("://") === -1) {
+	if (proxy?.includes("://")) {
 		// Missing scheme in proxy, default to the requested URL's scheme.
 		proxy = proto + "://" + proxy;
 	}
@@ -81,9 +82,9 @@ function shouldProxy(
 		if (!proxy) {
 			return true; // Skip zero-length hosts.
 		}
-		const parsedProxy = proxy.match(/^(.+):(\d+)$/);
+		const parsedProxy = /^(.+):(\d+)$/.exec(proxy);
 		let parsedProxyHostname = parsedProxy ? parsedProxy[1] : proxy;
-		const parsedProxyPort = parsedProxy ? parseInt(parsedProxy[2]) : 0;
+		const parsedProxyPort = parsedProxy ? Number.parseInt(parsedProxy[2]) : 0;
 		if (parsedProxyPort && parsedProxyPort !== port) {
 			return true; // Skip if ports don't match.
 		}
@@ -93,7 +94,7 @@ function shouldProxy(
 			return hostname !== parsedProxyHostname;
 		}
 
-		if (parsedProxyHostname.charAt(0) === "*") {
+		if (parsedProxyHostname.startsWith("*")) {
 			// Remove leading wildcard.
 			parsedProxyHostname = parsedProxyHostname.slice(1);
 		}

src/core/cliManager.ts

@@ -240,7 +240,7 @@ export class CliManager {
 		const newStat = await cliUtils.stat(binPath);
 		this.output.info(
 			"Downloaded binary size is",
-			prettyBytes(newStat?.size || 0),
+			prettyBytes(newStat?.size ?? 0),
 		);
 
 		// Make sure we can execute this new binary.

src/extension.ts

@@ -232,7 +232,7 @@ export async function activate(ctx: vscode.ExtensionContext): Promise<void> {
 				const detail = getErrorDetail(ex) || "None";
 				const urlString = axios.getUri(ex.config);
 				const method = ex.config?.method?.toUpperCase() || "request";
-				const status = ex.response?.status || "None";
+				const status = ex.response?.status ?? "None";
 				const message = `API ${method} to '${urlString}' failed.\nStatus code: ${status}\nMessage: ${msg}\nDetail: ${detail}`;
 				output.warn(message);
 				await vscodeProposed.window.showErrorMessage(

src/featureSet.ts

@@ -25,15 +25,15 @@ export function featureSetForVersion(
 		// If this check didn't exist, VS Code connections would fail on
 		// older versions because of an unknown CLI argument.
 		proxyLogDirectory:
-			(version?.compare("2.3.3") || 0) > 0 ||
+			(version?.compare("2.3.3") ?? 0) > 0 ||
 			version?.prerelease[0] === "devel",
 		wildcardSSH:
 			(version ? version.compare("2.19.0") : -1) >= 0 ||
 			version?.prerelease[0] === "devel",
 
 		// The --reason flag was added to `coder start` in 2.25.0
 		buildReason:
-			(version?.compare("2.25.0") || 0) >= 0 ||
+			(version?.compare("2.25.0") ?? 0) >= 0 ||
 			version?.prerelease[0] === "devel",
 	};
 }

src/headers.ts

@@ -95,11 +95,7 @@ export async function getHeaders(
 			const [key, value] = line.split(/=(.*)/);
 			// Header names cannot be blank or contain whitespace and the Coder CLI
 			// requires that there be an equals sign (the value can be blank though).
-			if (
-				key.length === 0 ||
-				key.indexOf(" ") !== -1 ||
-				typeof value === "undefined"
-			) {
+			if (key.length === 0 || key.includes(" ") || value === undefined) {
 				throw new Error(
 					`Malformed line from header command: [${line}] (out: ${result.stdout})`,
 				);

src/remote/remote.ts

@@ -774,9 +774,9 @@ export class Remote {
 
 		// deploymentConfig is now set from the remote coderd deployment.
 		// Now override with the user's config.
-		const userConfigSsh =
-			vscode.workspace.getConfiguration("coder").get<string[]>("sshConfig") ||
-			[];
+		const userConfigSsh = vscode.workspace
+			.getConfiguration("coder")
+			.get<string[]>("sshConfig", []);
 		const userConfig = parseSshConfig(userConfigSsh);
 		const sshConfigOverrides = mergeSshConfigValues(
 			deploymentSSHConfig,

src/remote/sshConfig.ts

@@ -1,5 +1,5 @@
-import { mkdir, readFile, rename, stat, writeFile } from "fs/promises";
-import path from "path";
+import { mkdir, readFile, rename, stat, writeFile } from "node:fs/promises";
+import path from "node:path";
 
 import { countSubstring } from "../util";
 
@@ -45,7 +45,7 @@ export function parseSshConfig(lines: string[]): Record<string, string> {
 	return lines.reduce(
 		(acc, line) => {
 			// Match key pattern (same as VS Code settings: ^[a-zA-Z0-9-]+)
-			const keyMatch = line.match(/^[a-zA-Z0-9-]+/);
+			const keyMatch = /^[a-zA-Z0-9-]+/.exec(line);
 			if (!keyMatch) {
 				return acc; // Malformed line
 			}
@@ -258,7 +258,7 @@ export class SSHConfig {
 		const lines = [this.startBlockComment(safeHostname), `Host ${Host}`];
 
 		// configValues is the merged values of the defaults and the overrides.
-		const configValues = mergeSshConfigValues(otherValues, overrides || {});
+		const configValues = mergeSshConfigValues(otherValues, overrides ?? {});
 
 		// keys is the sorted keys of the merged values.
 		const keys = Object.keys(configValues).sort();