Skip to content

Commit 335687d

Browse files
committed
Fix SVG icons for VS Code theme compatibility and reduce tasks font size
Activity bar icons use CSS mask-image, so only the alpha channel matters. Use a mask cutout on the C[] path to create a transparent card area for the bot icon, matching the original design where the bot sits on a white card overlapping the bottom-right of the square bracket. Align both activity bar icons to the same viewBox origin so C[] portions line up vertically. Simplify TreeItem icon SVGs by inlining fill colors instead of using CSS classes. Reduce the tasks webview base font size to 90% of the VS Code default for a more compact sidebar appearance.
1 parent 13744b2 commit 335687d

File tree

8 files changed

+368
-42
lines changed

8 files changed

+368
-42
lines changed

Store Session Tokens in the OS Keyring.md

Lines changed: 341 additions & 0 deletions
Large diffs are not rendered by default.

media/logo-black.svg

Lines changed: 3 additions & 11 deletions
Loading

media/logo-white.svg

Lines changed: 3 additions & 11 deletions
Loading

media/shorthand-logo.svg

Lines changed: 3 additions & 0 deletions
Loading

media/tasks-logo.svg

Lines changed: 11 additions & 3 deletions
Loading

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@
188188
{
189189
"id": "coder",
190190
"title": "Coder Remote",
191-
"icon": "media/logo-white.svg"
191+
"icon": "media/shorthand-logo.svg"
192192
},
193193
{
194194
"id": "coderTasks",

packages/tasks/src/index.css

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ body {
66
margin: 0;
77
padding: 0;
88
font-family: var(--vscode-font-family);
9-
font-size: var(--vscode-font-size);
9+
font-size: calc(var(--vscode-font-size) * 0.9);
1010
color: var(--vscode-foreground);
1111
background: var(--vscode-sideBar-background);
1212
overflow: hidden;
@@ -251,6 +251,7 @@ vscode-collapsible::part(body) {
251251
border-radius: 50%;
252252
flex-shrink: 0;
253253
background: var(--status-color);
254+
box-shadow: 0 0 0 0.25em color-mix(in srgb, var(--status-color) 25%, transparent);
254255
}
255256

256257
.status-dot.active {

src/webviews/tasks/tasksPanelProvider.ts

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,8 @@ export class TasksPanelProvider
107107
getTaskDetails: (p) => this.handleGetTaskDetails(p.taskId),
108108
createTask: (p) => this.handleCreateTask(p),
109109
deleteTask: (p) => this.handleDeleteTask(p.taskId, p.taskName),
110-
pauseTask: (p) => this.handlePauseTask(p.taskId, p.taskName),
111-
resumeTask: (p) => this.handleResumeTask(p.taskId, p.taskName),
110+
pauseTask: (p) => this.handlePauseTask(p.taskId),
111+
resumeTask: (p) => this.handleResumeTask(p.taskId),
112112
downloadLogs: (p) => this.handleDownloadLogs(p.taskId),
113113
sendTaskMessage: (p) => this.handleSendMessage(p.taskId, p.message),
114114
});
@@ -285,10 +285,7 @@ export class TasksPanelProvider
285285
);
286286
}
287287

288-
private async handlePauseTask(
289-
taskId: string,
290-
taskName: string,
291-
): Promise<void> {
288+
private async handlePauseTask(taskId: string): Promise<void> {
292289
const task = await this.client.getTask("me", taskId);
293290
if (!task.workspace_id) {
294291
throw new Error("Task has no workspace");
@@ -297,13 +294,9 @@ export class TasksPanelProvider
297294
await this.client.stopWorkspace(task.workspace_id);
298295

299296
await this.refreshAndNotifyTask(taskId);
300-
vscode.window.showInformationMessage(`Task "${taskName}" paused`);
301297
}
302298

303-
private async handleResumeTask(
304-
taskId: string,
305-
taskName: string,
306-
): Promise<void> {
299+
private async handleResumeTask(taskId: string): Promise<void> {
307300
const task = await this.client.getTask("me", taskId);
308301
if (!task.workspace_id) {
309302
throw new Error("Task has no workspace");
@@ -315,7 +308,6 @@ export class TasksPanelProvider
315308
);
316309

317310
await this.refreshAndNotifyTask(taskId);
318-
vscode.window.showInformationMessage(`Task "${taskName}" resumed`);
319311
}
320312

321313
private async handleSendMessage(
@@ -343,9 +335,6 @@ export class TasksPanelProvider
343335
}
344336

345337
await this.refreshAndNotifyTask(taskId);
346-
vscode.window.showInformationMessage(
347-
`Message sent to "${getTaskLabel(task)}"`,
348-
);
349338
}
350339

351340
private async handleViewInCoder(taskId: string): Promise<void> {

0 commit comments

Comments
 (0)