ArgumentError: API Key Required when setting key with block

[sunnyrjuneja]

I noticed when a key has not been set and you set one with a block, it will throw an argument error. Here is how you can reproduce this:

require 'congress'

Congress.new do |congress|
  congress.key = 'abcd'
end

This happens in ruby 2.1.0p0, gems version 2.2.1, congress version 0.2.1. The reason the test did not pick this up is the before block sets a key.

Full Stack Trace:

/Users/sunnyjuneja/.rvm/gems/ruby-2.1.0/gems/congress-0.2.1/lib/congress/client.rb:12:in `initialize': API key required (ArgumentError)
        from /Users/sunnyjuneja/.rvm/gems/ruby-2.1.0/gems/congress-0.2.1/lib/congress.rb:13:in `new'
        from /Users/sunnyjuneja/.rvm/gems/ruby-2.1.0/gems/congress-0.2.1/lib/congress.rb:13:in `new'
        from reproduce.rb:3:in `<main>'

[sferik]

This bug appears to have been introduced by #8.

[sunnyrjuneja]

@sferik I noticed the latest commit reverts the check for an api key. Is this a temporary or permanent change?

[sferik]

The latest commit fixes this issue. I’d like to find another way to warn the user that they’ve initialized a client without an API key before pushing a new release.

[sunnyrjuneja]

What do you think of replacing the raise ArguementError with Kernel#warn?

[sferik]

@whatasunnyday That could work.

[sunnyrjuneja]

@sferik Can I send a PR for this?

[sferik]

@whatasunnyday Sure! Ideally, it would only warn when the user tries making a request without setting the key.