refactor: wip

Author: BioPhoton

packages/utils/src/lib/profiler/profiler.ts

@@ -35,8 +35,12 @@ type ProfilerMeasureOptions<T extends Record<string, ActionTrackEntryPayload>> =
  *
  * @template T - Record type defining available track names and their configurations
  */
-export type ProfilerOptions<T extends Record<string, ActionTrackEntryPayload>> =
-  ProfilerMeasureOptions<T>;
+export type ProfilerOptions<
+  T extends Record<string, ActionTrackEntryPayload> = Record<
+    string,
+    ActionTrackEntryPayload
+  >,
+> = ProfilerMeasureOptions<T>;
 
 /**
  * Performance profiler that creates structured timing measurements with DevTools visualization.
@@ -127,7 +131,7 @@ export class Profiler<T extends Record<string, ActionTrackEntryPayload>> {
    *   ]
    * });
    */
-  marker(name: string, opt?: EntryMeta & { color: DevToolsColor }) {
+  marker(name: string, opt?: EntryMeta & { color?: DevToolsColor }) {
     if (!this.#enabled) {
       return;
     }

packages/utils/src/lib/profiler/profiler.unit.test.ts

@@ -1,30 +1,30 @@
 import { performance } from 'node:perf_hooks';
 import { beforeEach, describe, expect, it, vi } from 'vitest';
 import type { ActionTrackEntryPayload } from '../user-timing-extensibility-api.type.js';
-import { Profiler } from './profiler.js';
+import { Profiler, type ProfilerOptions } from './profiler.js';
 
 describe('Profiler', () => {
+  const getProfiler = (overrides?: Partial<ProfilerOptions>) =>
+    new Profiler({
+      prefix: 'cp',
+      track: 'test-track',
+      ...overrides,
+    });
+
   let profiler: Profiler<Record<string, ActionTrackEntryPayload>>;
 
   beforeEach(() => {
     performance.clearMarks();
     performance.clearMeasures();
+    // eslint-disable-next-line functional/immutable-data
     delete process.env.CP_PROFILING;
 
-    profiler = new Profiler({
-      prefix: 'cp',
-      track: 'test-track',
-      tracks: {},
-    });
+    profiler = getProfiler();
   });
 
   it('constructor should initialize with default enabled state from env', () => {
     vi.stubEnv('CP_PROFILING', 'true');
-    const profilerWithEnv = new Profiler({
-      prefix: 'cp',
-      track: 'test-track',
-      tracks: {},
-    });
+    const profilerWithEnv = getProfiler();
 
     expect(profilerWithEnv.isEnabled()).toBe(true);
   });
@@ -34,20 +34,14 @@ describe('Profiler', () => {
     const profilerWithOverride = new Profiler({
       prefix: 'cp',
       track: 'test-track',
-      tracks: {},
       enabled: true,
     });
 
     expect(profilerWithOverride.isEnabled()).toBe(true);
   });
 
   it('constructor should use defaults for measure', () => {
-    const customProfiler = new Profiler({
-      prefix: 'custom',
-      track: 'custom-track',
-      trackGroup: 'custom-group',
-      color: 'secondary',
-    });
+    const customProfiler = getProfiler({ color: 'secondary' });
 
     customProfiler.setEnabled(true);
 
@@ -61,23 +55,21 @@ describe('Profiler', () => {
     expect(marks).toStrictEqual(
       expect.arrayContaining([
         expect.objectContaining({
-          name: 'custom:test-operation:start',
+          name: 'cp:test-operation:start',
           detail: {
             devtools: expect.objectContaining({
               dataType: 'track-entry',
-              track: 'custom-track',
-              trackGroup: 'custom-group',
+              track: 'test-track',
               color: 'secondary',
             }),
           },
         }),
         expect.objectContaining({
-          name: 'custom:test-operation:end',
+          name: 'cp:test-operation:end',
           detail: {
             devtools: expect.objectContaining({
               dataType: 'track-entry',
-              track: 'custom-track',
-              trackGroup: 'custom-group',
+              track: 'test-track',
               color: 'secondary',
             }),
           },
@@ -86,12 +78,11 @@ describe('Profiler', () => {
     );
     expect(measures).toStrictEqual([
       expect.objectContaining({
-        name: 'custom:test-operation',
+        name: 'cp:test-operation',
         detail: {
           devtools: expect.objectContaining({
             dataType: 'track-entry',
-            track: 'custom-track',
-            trackGroup: 'custom-group',
+            track: 'test-track',
             color: 'secondary',
           }),
         },
@@ -186,12 +177,7 @@ describe('Profiler', () => {
   it('marker should execute without error when enabled with default color', () => {
     performance.clearMarks();
 
-    const profilerWithColor = new Profiler({
-      prefix: 'cp',
-      track: 'test-track',
-      color: 'primary',
-      tracks: {},
-    });
+    const profilerWithColor = getProfiler({ color: 'primary' });
     profilerWithColor.setEnabled(true);
 
     expect(() => {
@@ -216,11 +202,7 @@ describe('Profiler', () => {
   });
 
   it('marker should execute without error when enabled with no default color', () => {
-    const profilerNoColor = new Profiler({
-      prefix: 'cp',
-      track: 'test-track',
-      tracks: {},
-    });
+    const profilerNoColor = getProfiler();
     profilerNoColor.setEnabled(true);
 
     expect(() => {