Skip to content

Commit 03c8484

Browse files
author
John Doe
committed
refactor: fix typing
1 parent 510566f commit 03c8484

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

packages/utils/src/lib/trace-file-utils.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ export const getInstantEvent = (opt: {
4848
ts?: number;
4949
pid?: number;
5050
tid?: number;
51-
args?: InstantEventArgs;
51+
args: InstantEventArgs;
5252
}): InstantEvent => ({
5353
cat: 'blink.user_timing',
5454
ph: 'i',
@@ -113,7 +113,7 @@ type SpanOpt = {
113113
ts?: number;
114114
pid?: number;
115115
tid?: number;
116-
args?: SpanEventArgs;
116+
args: SpanEventArgs;
117117
};
118118

119119
export function getSpanEvent(ph: 'b', opt: SpanOpt): BeginEvent;
@@ -138,7 +138,7 @@ export const getSpan = (opt: {
138138
id2?: { local: string };
139139
pid?: number;
140140
tid?: number;
141-
args?: SpanEventArgs;
141+
args: SpanEventArgs;
142142
tsMarkerPadding?: number;
143143
}): [BeginEvent, EndEvent] => {
144144
// tsMarkerPadding is here to make the measure slightly smaller so the markers align perfectly.

packages/utils/src/lib/trace-file.type.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,17 +5,17 @@ import type { UserTimingDetail } from './user-timing-extensibility-api.type';
55
* @property {UserTimingDetail} [detail] - Optional user timing detail with DevTools payload
66
*/
77
export type InstantEventArgs = {
8-
detail?: UserTimingDetail & Record<string, unknown>;
9-
};
8+
detail?: UserTimingDetail;
9+
} & { [key: string]: unknown };
1010

1111
/**
1212
* Arguments for span trace events (begin/end events).
1313
* @property {object} [data] - Optional data object
1414
* @property {UserTimingDetail} [data.detail] - Optional user timing detail with DevTools payload
1515
*/
1616
export type SpanEventArgs = {
17-
data?: { detail?: UserTimingDetail & Record<string, unknown> };
18-
};
17+
data?: { detail?: UserTimingDetail };
18+
} & { [key: string]: unknown };
1919

2020
/**
2121
* Arguments for complete trace events.

0 commit comments

Comments
 (0)