Skip to content

Commit aa2a7e5

Browse files
committed
chore: fix redundant runs and remove test that randomly fails
1 parent f74936e commit aa2a7e5

File tree

2 files changed

+6
-15
lines changed

2 files changed

+6
-15
lines changed

.github/workflows/ci.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@ on:
88
- 'LICENSE'
99
- '.gitignore'
1010
pull_request:
11+
branches-ignore:
12+
- 'chore/version-bump-*'
1113
paths-ignore:
1214
- '**.md'
1315
- 'docs/**'

tests/plugin_tests.rs

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,11 @@
1+
use serial_test::serial;
12
use std::fs;
23
use std::os::unix::fs::PermissionsExt;
34
use std::process::Command;
45
use tempfile::TempDir;
56

67
#[test]
8+
#[serial]
79
fn test_plugin_system_integration() {
810
// Create a temporary directory for our test plugin
911
let temp_dir = TempDir::new().unwrap();
@@ -122,27 +124,14 @@ exit 0
122124
}
123125

124126
#[test]
127+
#[serial]
125128
fn test_builtin_commands_still_work() {
126129
// Ensure built-in commands are not affected by plugin system
127130

128131
// Get the current working directory to ensure we run commands from the right place
129132
let current_dir = std::env::current_dir().expect("Failed to get current directory");
130133

131-
// Build the binary first to avoid compilation races
132-
let build_output = Command::new("cargo")
133-
.args(["build"])
134-
.current_dir(&current_dir)
135-
.output()
136-
.expect("Failed to build binary");
137-
138-
if !build_output.status.success() {
139-
eprintln!("Build failed:");
140-
eprintln!("stdout: {}", String::from_utf8_lossy(&build_output.stdout));
141-
eprintln!("stderr: {}", String::from_utf8_lossy(&build_output.stderr));
142-
panic!("Cannot run tests without successful build");
143-
}
144-
145-
// Test help command
134+
// Test help command (cargo run will build if needed)
146135
let output = Command::new("cargo")
147136
.args(["run", "--", "--help"])
148137
.current_dir(&current_dir)

0 commit comments

Comments
 (0)