From b3d7ae219b35c3bd7e1ac7361e480a18bf7009d3 Mon Sep 17 00:00:00 2001 From: "codacydemo@codacy.com" Date: Tue, 3 Sep 2019 10:38:20 +0100 Subject: [PATCH 1/3] Added HelloWorld20193803103820.java --- .../resources/HelloWorld20193803103820.java | 58 +++++++++++++++++++ .../HelloWorld20193803103820Test.java | 38 ++++++++++++ 2 files changed, 96 insertions(+) create mode 100644 src/main/java/com/javademo/resources/HelloWorld20193803103820.java create mode 100644 src/test/java/com/javademo/resources/HelloWorld20193803103820Test.java diff --git a/src/main/java/com/javademo/resources/HelloWorld20193803103820.java b/src/main/java/com/javademo/resources/HelloWorld20193803103820.java new file mode 100644 index 0000000..3878674 --- /dev/null +++ b/src/main/java/com/javademo/resources/HelloWorld20193803103820.java @@ -0,0 +1,58 @@ +package com.javademo.resources; + +import com.google.common.base.Optional; +import com.codahale.metrics.annotation.Timed; + +import javax.ws.rs.GET; +import javax.ws.rs.Path; +import javax.ws.rs.Produces; +import javax.ws.rs.QueryParam; +import javax.ws.rs.core.MediaType; +import java.util.concurrent.atomic.AtomicLong; + +import java.sql.*; +import java.util.Properties; +import java.util.concurrent.Executor; +import java.util.Map; + + +@Path("/hello-world-20193803103820") +@Produces(MediaType.APPLICATION_JSON) +public class HelloWorld20193803103820 { + private final String template; + private final String defaultName; + private final AtomicLong counter; + + public HelloWorld20193803103820(String template, String defaultName) { + this.template = template; + this.defaultName = defaultName; + this.counter = new AtomicLong(); + } + + @GET + @Timed + public void sayHello(@QueryParam("name") Optional name) { + final String value = String.format(template, name.or(defaultName)); + } + + public Connection generateConnection(){ + //TODO: implement a connection method + return null; + } + + public double add(int x, int y){ + return (double) x+y; + } + + @GET + public void TestSQLInjection(@QueryParam("userid") Optional userId, @QueryParam("password") Optional password){ + Connection connection = generateConnection(); + try{ + String query = "SELECT * FROM users WHERE userid ='"+ userId.or(0) + "'" + " AND password='" + password.or("YAY") + "'"; + Statement stmt = connection.createStatement(); + ResultSet rs = stmt.executeQuery(query); + }catch(Exception ex){ + ex.printStackTrace(); + } + } +} \ No newline at end of file diff --git a/src/test/java/com/javademo/resources/HelloWorld20193803103820Test.java b/src/test/java/com/javademo/resources/HelloWorld20193803103820Test.java new file mode 100644 index 0000000..3a1b772 --- /dev/null +++ b/src/test/java/com/javademo/resources/HelloWorld20193803103820Test.java @@ -0,0 +1,38 @@ +package com.javademo.resources; + + +import com.google.common.base.Optional; + + + +import org.junit.*; +import static org.assertj.core.api.Assertions.assertThat; + +public class HelloWorld20193803103820Test { + private HelloWorld20193803103820 resource; + + public void setup() { + System.out.println("YAY"); + } + + + public void testDumb() { + resource = new HelloWorld20193803103820("Hello, %s", "Stranger"); + Optional empty = Optional.absent(); + Optional emptyInteger = Optional.absent(); + resource.sayHello(empty); + resource.TestSQLInjection(emptyInteger,empty); + } + + @Test + public void testAdd() { + resource = new HelloWorld20193803103820("Hello, %s", "Stranger"); + + double result = resource.add(7,9); + //assertThat("y").isEqualTo("y"); + assertThat(result).isEqualTo((double) 7+9); + } + + + +} \ No newline at end of file From f6d5d19b79e3ddc4e6999ea768a74bf18ea4b77c Mon Sep 17 00:00:00 2001 From: "codacydemo@codacy.com" Date: Tue, 3 Sep 2019 10:40:50 +0100 Subject: [PATCH 2/3] Fixed Java errors --- .../resources/HelloWorld20193803103820.java | 27 +++++-------------- 1 file changed, 7 insertions(+), 20 deletions(-) diff --git a/src/main/java/com/javademo/resources/HelloWorld20193803103820.java b/src/main/java/com/javademo/resources/HelloWorld20193803103820.java index 3878674..0f289ad 100644 --- a/src/main/java/com/javademo/resources/HelloWorld20193803103820.java +++ b/src/main/java/com/javademo/resources/HelloWorld20193803103820.java @@ -11,22 +11,16 @@ import java.util.concurrent.atomic.AtomicLong; import java.sql.*; -import java.util.Properties; -import java.util.concurrent.Executor; -import java.util.Map; - @Path("/hello-world-20193803103820") @Produces(MediaType.APPLICATION_JSON) public class HelloWorld20193803103820 { - private final String template; - private final String defaultName; - private final AtomicLong counter; + private transient final String template; + private transient final String defaultName; public HelloWorld20193803103820(String template, String defaultName) { this.template = template; this.defaultName = defaultName; - this.counter = new AtomicLong(); } @GET @@ -35,24 +29,17 @@ public void sayHello(@QueryParam("name") Optional name) { final String value = String.format(template, name.or(defaultName)); } + public double add(int x, int y){ + return (double) x+y; + } + public Connection generateConnection(){ //TODO: implement a connection method return null; } - public double add(int x, int y){ - return (double) x+y; - } - @GET public void TestSQLInjection(@QueryParam("userid") Optional userId, @QueryParam("password") Optional password){ - Connection connection = generateConnection(); - try{ - String query = "SELECT * FROM users WHERE userid ='"+ userId.or(0) + "'" + " AND password='" + password.or("YAY") + "'"; - Statement stmt = connection.createStatement(); - ResultSet rs = stmt.executeQuery(query); - }catch(Exception ex){ - ex.printStackTrace(); - } + return; } } \ No newline at end of file From 42baad3d12d1ca1123dd330957a68c725304e523 Mon Sep 17 00:00:00 2001 From: "codacydemo@codacy.com" Date: Fri, 6 Sep 2019 15:04:21 +0100 Subject: [PATCH 3/3] Fixed Java errors