Remove "old" LHCInfo tag from Run3 GTs

[francescobrivio]

Description

In Run 3 we plan to switch from the "old" LHCInfo format, to the new records LHCInfoPerFill + LHCInfoPerLS.
Once the following PRs:

• To update PPS reco CTPPS reco update to use LHCInfoPer* records cms-sw/cmssw#42515
• To add the new records to the GTs Add 132X data and MC GTs cms-sw/cmssw#42551

are merged, we can proceed with the removal of the following "old" LHCInfo tag from:

GT	Tag to be removed
run3_hlt	LHCInfo_hlt_forPPS
run3_data_express	LHCInfo_hlt_forPPS
run3_data_prompt	LHCInfoEndFill_Run3_v0
run3_data	LHCInfoEndFill_prompt_v2
phase1_2022_design	LHCInfo_2021_mc_v2
phase1_2022_realistic	LHCInfo_2021_mc_v2
phase1_2022_realistic_postEE	LHCInfo_2021_mc_v2
phase1_2022_cosmics	LHCInfo_2021_mc_v2
phase1_2022_cosmics_design	LHCInfo_2021_mc_v2
phase1_2022_realistic_hi	LHCInfo_2021_mc_v2
phase1_2023_design	LHCInfo_2021_mc_v2
phase1_2023_realistic	LHCInfo_2021_mc_v2
phase1_2023_realistic_postBPix	LHCInfo_2021_mc_v2
phase1_2023_cosmics	LHCInfo_2021_mc_v2
phase1_2023_cosmics_design	LHCInfo_2021_mc_v2
phase1_2023_realistic_hi	LHCInfo_2021_mc_v2
phase1_2024_realistic	LHCInfo_2021_mc_v2

Important Note

Before cleaning up the online GTs (HLT/Express/Prompt) we should make sure the O2Os writing to the new LHCInfo tags are up and running.

[francescobrivio]

Before proceeding with the removal of the old LHCInfo tag from all the GTs we should make sure to cleanup properly all the consuming code in CMSSW.
Here is a preliminary list compiled from a quick search in CMSSW:

• Cleanup only needed (commented lines):
  • https://github.com/cms-sw/cmssw/blob/master/CalibTracker/SiPixelQuality/plugins/SiPixelStatusHarvester.cc#L28
  • https://github.com/cms-sw/cmssw/blob/master/DQM/CTPPS/plugins/CTPPSDiamondDQMSource.cc#L41
• Fix needed:

  • PPS:

    • https://github.com/cms-sw/cmssw/blob/master/SimTransport/PPSProtonTransport/interface/OpticalFunctionsTransport.h#L9
    • https://github.com/cms-sw/cmssw/blob/master/HLTrigger/special/plugins/HLTPPSJetComparisonFilter.cc#L24
      • This is related to HLT - see https://its.cern.ch/jira/browse/CMSHLT-3030
    • https://github.com/cms-sw/cmssw/blob/master/SimPPS/DirectSimProducer/plugins/PPSDirectProtonSimulation.cc#L37

  • Others:

    • https://github.com/cms-sw/cmssw/blob/master/PhysicsTools/NanoAOD/plugins/LHCInfoProducer.cc#L49
    • https://github.com/cms-sw/cmssw/blob/master/Calibration/EcalCalibAlgos/plugins/EcalPhiSymRecHitProducers.cc#L39

The fix should consist in the migration of the modules to use LHCInfoCombined.
Previous examples of such migration can be found in the following PRs:

• CTPPS reco update to use LHCInfoPer* records cms-sw/cmssw#42515
• CTPPS update Run3 Direct Simulation to use old LHCInfo after LHCInfo update cms-sw/cmssw#42890

FYI @vavati @JanChyczynski @grzanka @Glitchmin @mmusich

[francescobrivio]

See cms-sw/cmssw#43951 for HLTrigger/special/plugins/HLTPPSJetComparisonFilter.cc

[saumyaphor4252]

Two more GTs containing old LHCInfoRcd, in addition to the ones mentioned in the description above :

Key/GT	Tag to be removed
phase1_2023_cosmics_postBPix	LHCInfo_2021_mc_v2
phase1_2024_cosmics_design	LHCInfo_2021_mc_v2