-
Notifications
You must be signed in to change notification settings - Fork 2
Continue on fail isn't handled at the Stage level #93
Copy link
Copy link
Open
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed
Description
Describe the bug
The --continue option can be provided on the command-line to apply continue on fail behavior to all stages. However, individual stages can not be set to continue on fail, despite continue on fail: true being available for each stage.
To Reproduce
Steps to reproduce the behavior:
- In a new Config File, create a
stagewithcontinue on fail: true - Create a command that will deliberately fail such as
cp. - Run build-magic with the Config File.
Expected behavior
continue on fail: true should work per stage.
Additional context
The problem is because continue_on_fail is an argument for the Engine constructor and not the Stage.build() method. The continue on fail behavior should be moved to the Stage object.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomershelp wantedExtra attention is neededExtra attention is needed