Skip to content

HTTP errors should be returned by cshark #9

@thomasp11

Description

@thomasp11

If there is any issue during the upload where CloudShark returns a non 200 OK response the cshark plugin returns a generic message back to the client:

cshark/src/uclient.c

Lines 44 to 51 in c0d32fb

static void cshark_header_done_cb(struct uclient *ucl)
{
if (ucl->status_code != 200) {
ERROR("%s: received error, please double check your config file\n", PROJECT_NAME);
uclient_disconnect(ucl);
uloop_end();
}
}

static void cshark_header_done_cb(struct uclient *ucl)
{
	if (ucl->status_code != 200) {
		ERROR("%s: received error, please double check your config file\n", PROJECT_NAME);
		uclient_disconnect(ucl);
		uloop_end();
	}
}

This should also return the error code and message sent by the CloudShark server to the client.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions