Merge pull request #72 from cloudblue/client_mocker_fixture_did_not_reset

[Fix] client_mocker_factory didn't finalize mocker

Author: ffaraone

connect/client/testing/fixtures.py

@@ -17,6 +17,7 @@ def client_mocker_factory(request):
     mocker = None
 
     def _wrapper(base_url='https://example.org/public/v1', exclude=None):
+        nonlocal mocker
         mocker = ConnectClientMocker(base_url, exclude=exclude)
         mocker.start()
         return mocker

tests/client/test_fixtures.py

@@ -1,6 +1,7 @@
+import pytest
 import requests
 
-from connect.client import ConnectClient
+from connect.client import ClientError, ConnectClient
 
 
 def test_client_mocker_factory(client_mocker_factory):
@@ -11,6 +12,12 @@ def test_client_mocker_factory(client_mocker_factory):
     assert client.products.create(payload={}) == {'id': 'PRD-000'}
 
 
+def test_client_mocker_factory_finalizer():
+    client = ConnectClient('api_key', endpoint='http://example.com')
+    with pytest.raises(ClientError):
+        client.products.create(payload={})
+
+
 def test_client_mocker_factory_default_base_url(client_mocker_factory):
     mocker = client_mocker_factory()
     mocker.products.create(return_value={'id': 'PRD-000'})