Merge pull request #54 from cloudblue/change_default_base_url_for_mockers

Change default base url for client mockers

Author: ffaraone

connect/client/testing/fixtures.py

@@ -11,7 +11,7 @@ def client_mocker_factory(request):
     """
     mocker = None
 
-    def _wrapper(base_url='http://localhost'):
+    def _wrapper(base_url='https://example.org/public/v1'):
         mocker = ConnectClientMocker(base_url)
         mocker.start()
         return mocker
@@ -32,7 +32,7 @@ def async_client_mocker_factory(request):
     """
     mocker = None
 
-    def _wrapper(base_url='http://localhost'):
+    def _wrapper(base_url='https://example.org/public/v1'):
         mocker = AsyncConnectClientMocker(base_url)
         mocker.start()
         return mocker

docs/testing.md

@@ -56,7 +56,7 @@ def test_get_all_products(client_mocker_factory):
 
     expected_response = [{'id': 'PRD-000'}]
 
-    mocker = client_mocker_factory(client.endpoint)
+    mocker = client_mocker_factory(base_url=client.endpoint)
     mocker.products.all().mock(return_value=expected_response)
 
     assert list(client.products.all()) == expected_response

tests/client/test_fixtures.py

@@ -7,3 +7,11 @@ def test_client_mocker_factory(client_mocker_factory):
 
     client = ConnectClient('api_key', endpoint='http://example.com')
     assert client.products.create(payload={}) == {'id': 'PRD-000'}
+
+
+def test_client_mocker_factory_default_base_url(client_mocker_factory):
+    mocker = client_mocker_factory()
+    mocker.products.create(return_value={'id': 'PRD-000'})
+
+    client = ConnectClient('api_key', endpoint='https://example.org/public/v1')
+    assert client.products.create(payload={}) == {'id': 'PRD-000'}