Merge pull request #15 from cloudblue/fix_default_limit

fix default limit and make client thread safe

Author: marcserrat

cnct/client/fluent.py

@@ -1,3 +1,5 @@
+import threading
+
 from json.decoder import JSONDecodeError
 
 import requests
@@ -11,7 +13,7 @@
 from cnct.client.openapi import OpenAPISpecs
 
 
-class ConnectClient:
+class ConnectClient(threading.local):
     """
     Connect ReST API client.
     """
@@ -43,6 +45,7 @@ def __init__(
         self.endpoint = endpoint or CONNECT_ENDPOINT_URL
         self.api_key = api_key
         self.default_headers = default_headers or {}
+        self.default_limit = default_limit
         self._use_specs = use_specs
         self._validate_using_specs = validate_using_specs
         self.specs_location = specs_location or CONNECT_SPECS_URL

cnct/client/models/resourceset.py

@@ -74,7 +74,7 @@ def __init__(
         self._query = query or R()
         self._results = None
         self._result_iterator = None
-        self._limit = 100
+        self._limit = self._client.default_limit or 100
         self._offset = 0
         self._slice = False
         self._content_range = None

tests/client/test_fluent.py

@@ -26,6 +26,18 @@ def test_default_headers_invalid():
         )
 
 
+def test_default_limit():
+    c = ConnectClient(
+        'Api Key',
+        use_specs=False,
+        default_limit=10,
+    )
+
+    rs = c.products.all()
+
+    assert rs._limit == 10
+
+
 # def test_getattr(mocker):
 #     c = ConnectClient('Api Key', use_specs=False)
 

tests/fixtures/client_models.py

@@ -63,6 +63,7 @@ def _action_factory(
 def rs_factory(mocker):
     client = mocker.MagicMock()
     client._endpoint = 'https://example.com/api/v1'
+    client.default_limit = None
 
     def _rs_factory(
         client=client,