Need fix error handling in doLogin function. file /node-vtiger/lib/nodevtiger.js line 156

[TuliantsevViktor]

request(this._wsUrl + params, function(# e, r, body) {
var response;
if (e) {
_this.log.error("doLogin: request getChallenge -> error: " + (JSON.stringify(# error)));
_this._lastError = {
"error": {
"code": "ERROR_ON_REQUEST",
"message": "Error on request (get challenge)"
}
};

[tsabbay]

hi guys the problem is as follow:
if trying to connect with invalid vtiger end point(not a vtigder host) it will throw an un handled exception, we suggest to fix a bit to make it bit better (:

before :
request(this._wsUrl + params, function(e, r, body) {
var response;
if (e) {
_this.log.error("doLogin: request getChallenge -> error: " + (JSON.stringify(error)));
_this._lastError = {
"error": {
"code": "ERROR_ON_REQUEST",
"message": "Error on request (get challenge)"
}
};
after:
request(this._wsUrl + params, function(e, r, body) {
var response;
if (e) {
_this.log.error("doLogin: request getChallenge -> error: " + (JSON.stringify(e)));
_this._lastError = {
"error": {
"code": "ERROR_ON_REQUEST",
"message": "Error on request (get challenge)"
}
};