Commit issue with device in bad connection state #239
Description
If you have a device in a bad connection state, as the uk-hex device here:
root@nsolab-02> show connections
Name State Time Logmsg
==============================================================================================================================================================================================================================================
dk-bal-leaf-01 OPEN 2026-01-22T09:35:36
dk-bal-spine-01 OPEN 2026-01-22T09:35:36
dk-ore2-leaf-01 OPEN 2026-01-22T09:35:35
dk-ore2-leaf-02 OPEN 2026-01-22T09:35:30
dk-ore2-spine-01 CLOSED
test-01 OPEN 2026-01-22T09:35:29
test-02 OPEN 2026-01-22T09:35:30
test-broken-ip CLOSED 2026-01-22T09:36:08 Timeout waiting for remote peer
uk-hex CLOSED 2026-01-22T09:35:08 No ED25519 host key is known for [2001:948:0:f006::13]:830 and you have requested strict checking.
The show compare command reveals that all device config appears replaced (there are over 8 thousand lines so I wont paste it here). Rollback and try to commit a service and this error occurs, causing the service to crash:
Jan 22 09:41:32 nsolab-02 clixon_server.p[926854]: pyserver[926854] evpn.py:275: EVPN service: interfaces compiled
Jan 22 09:41:33 nsolab-02 clixon_backend[926852]: xmldb_readfile: 613: UNIX error: open(/usr/local/var/controller/device-test-broken-ip-SYNCED.d/0.xml): No such file or directory
Jan 22 09:41:33 nsolab-02 clixon_backend[926852]: Jan 22 09:41:33.223865: xmldb_readfile: 613: UNIX error: open(/usr/local/var/controller/device-test-broken-ip-SYNCED.d/0.xml): No such file or directory
Jan 22 09:41:33 nsolab-02 clixon_backend[926852]: Jan 22 09:41:33.223926: from_client_msg Error in rpc_callback_call:transaction-actions-done
Jan 22 09:41:33 nsolab-02 clixon_backend[926852]: from_client_msg Error in rpc_callback_call:transaction-actions-done
Jan 22 09:41:34 nsolab-02 clixon_backend[926852]: controller_transaction_wait: 875: Yang error: Inconsistent states: (notready||wait) && other
Jan 22 09:41:34 nsolab-02 clixon_backend[926852]: Jan 22 09:41:34.893680: controller_transaction_wait: 875: Yang error: Inconsistent states: (notready||wait) && other
Jan 22 09:41:34 nsolab-02 clixon_backend[926852]: Jan 22 09:41:34.893714: clixon_backend: 926852 Terminated retval:-1
Jan 22 09:41:34 nsolab-02 clixon_backend[926852]: clixon_backend: 926852 Terminated retval:-1
Jan 22 09:41:42 nsolab-02 clixon_server.p[926854]: pyserver[926854] client.py:321: Socket closed, backend probably died
sometimes the path /usr/local/var/controller/device-test-broken-ip-SYNCED.d/0.xml is uk-hex's instead but they are both missing and the result is the same.
Interestingly, clixon does not crash if it is only the test-broken-ip device that is enabled.