show compare private candidate

[denniswa]

From terminal1

snc@snc-lab[/]# show compare
         serviceID SU-S003058 sunet-oso {
-           description "TEST9";
+           description "TEST10";
         }
snc@snc-lab[/]# commit local
snc@snc-lab[/]#

From terminal2

snc@snc-lab[/]# set services service1 XXXX serviceID SU-S003058 sunet-oso description TEST11
snc@snc-lab[/]# show compare
         serviceID SU-S003058 sunet-oso {
-           description "TEST9";
+           description "TEST11";
         }
snc@snc-lab[/]# show compare
         serviceID SU-S003058 sunet-oso {
-           description "TEST10";
+           description "TEST11";
         }
snc@snc-lab[/]#

Another case if you run show compare one cli first and then commit in another cli you will see a diff afterwards:

CLI1:
snc@snc-lab[/]# set services service1 XXXX serviceID SU-S003058 sunet-oso description TEST13
snc@snc-lab[/]# commit local
snc@snc-lab[/]#

CLI2:
snc@snc-lab> show compare  <-- this command was run before set in CLI1
snc@snc-lab> show compare
         serviceID SU-S003058 sunet-oso {
-           description "TEST13";
+           description "TEST12";
         }
snc@snc-lab>

the output from second show compare in CLI2 is unexpected

[olofhagsand]

The problem is that show configure of candidate-db (and thereby other show commands) creates a candidate from running at the time of the show. Then that datastore remains. But in the privcand work (and draft) the candidate datastore should be created on first edit.
The proposed fix is to just return running if show configure candidate is requested without creating a new candidate.
An alternative way would be to create the privcand when opening "configure" mode as is done on some platforms. However, clixon does not mandate such a mode, and therefore would require a special RPC, ie configure-open, which would lead to an API change.

[denniswa]

I kind of like the "create when configure" even if you do not edit, however It makes more sense to create candidate on first edit. Both works