From bf903d50990f14b77bf0f26b7803b62a27267a85 Mon Sep 17 00:00:00 2001 From: zumba Date: Wed, 24 Jan 2018 12:33:15 +0200 Subject: [PATCH 1/3] Add phpunit.xml to .gitignore --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 2b4c99e..03873de 100644 --- a/.gitignore +++ b/.gitignore @@ -1,3 +1,4 @@ bin/* composer.lock vendor/* +/phpunit.xml \ No newline at end of file From 4ee4ce08f637ffd3906b1658dbcbdede7e357114 Mon Sep 17 00:00:00 2001 From: zumba Date: Wed, 24 Jan 2018 12:34:01 +0200 Subject: [PATCH 2/3] Fix unquoted parameter references deprecated since Sf3.1 --- Resources/config/services.yml | 12 ++++++------ composer.json | 3 ++- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/Resources/config/services.yml b/Resources/config/services.yml index d3f8531..867f8af 100644 --- a/Resources/config/services.yml +++ b/Resources/config/services.yml @@ -7,18 +7,18 @@ parameters: services: cl_slack.api_client: - class: %cl_slack.api_client.class% + class: "%cl_slack.api_client.class%" arguments: - - %cl_slack.api_token% + - "%cl_slack.api_token%" cl_slack.mock_api_client: - class: %cl_slack.mock_api_client.class% + class: "%cl_slack.mock_api_client.class%" cl_slack.model_serializer: - class: %cl_slack.model_serializer.class% + class: "%cl_slack.model_serializer.class%" cl_slack.payload_serializer: - class: %cl_slack.payload_serializer.class% + class: "%cl_slack.payload_serializer.class%" cl_slack.payload_response_serializer: - class: %cl_slack.payload_response_serializer.class% + class: "%cl_slack.payload_response_serializer.class%" diff --git a/composer.json b/composer.json index e3e02a1..c396f37 100644 --- a/composer.json +++ b/composer.json @@ -24,7 +24,8 @@ "require-dev": { "phpunit/phpunit": "^4.0|^5.0", "matthiasnoback/symfony-config-test": "^0.2", - "matthiasnoback/symfony-dependency-injection-test": "^0.7" + "matthiasnoback/symfony-dependency-injection-test": "^0.7", + "symfony/phpunit-bridge": "^3.1" }, "suggest": { "cleentfaar/slack-cli": "Command-line application for interacting with the Slack API" From c5dba83439bd1797c499ad139016fc52247b254a Mon Sep 17 00:00:00 2001 From: zumba Date: Wed, 24 Jan 2018 12:35:07 +0200 Subject: [PATCH 3/3] Remove reference to non-existing class --- Resources/config/services.yml | 4 ---- Tests/DependencyInjection/ExtensionTest.php | 1 - 2 files changed, 5 deletions(-) diff --git a/Resources/config/services.yml b/Resources/config/services.yml index 867f8af..73a4f39 100644 --- a/Resources/config/services.yml +++ b/Resources/config/services.yml @@ -1,7 +1,6 @@ parameters: cl_slack.api_client.class: CL\Slack\Transport\ApiClient cl_slack.mock_api_client.class: CL\Slack\Test\Transport\MockApiClient - cl_slack.model_serializer.class: CL\Slack\Serializer\ModelSerializer cl_slack.payload_serializer.class: CL\Slack\Serializer\PayloadSerializer cl_slack.payload_response_serializer.class: CL\Slack\Serializer\PayloadResponseSerializer @@ -14,9 +13,6 @@ services: cl_slack.mock_api_client: class: "%cl_slack.mock_api_client.class%" - cl_slack.model_serializer: - class: "%cl_slack.model_serializer.class%" - cl_slack.payload_serializer: class: "%cl_slack.payload_serializer.class%" diff --git a/Tests/DependencyInjection/ExtensionTest.php b/Tests/DependencyInjection/ExtensionTest.php index a0293c3..2d2e8ea 100644 --- a/Tests/DependencyInjection/ExtensionTest.php +++ b/Tests/DependencyInjection/ExtensionTest.php @@ -34,7 +34,6 @@ public function it_loads_the_expected_services() $this->assertContainerBuilderHasServiceDefinitionWithArgument('cl_slack.api_client', 0, '%cl_slack.api_token%'); $this->assertContainerBuilderHasService('cl_slack.mock_api_client', 'CL\Slack\Test\Transport\MockApiClient'); - $this->assertContainerBuilderHasService('cl_slack.model_serializer', 'CL\Slack\Serializer\ModelSerializer'); $this->assertContainerBuilderHasService('cl_slack.payload_serializer', 'CL\Slack\Serializer\PayloadSerializer'); $this->assertContainerBuilderHasService('cl_slack.payload_response_serializer', 'CL\Slack\Serializer\PayloadResponseSerializer'); }