Capture Week -> Capture Period

[AronGahagan]

Description

Rename Capture Week to Capture Period in all user-facing text AND ensure all processes are aligned (no assumptions that the prior period was, e.g., DateAdd("d", dtStatus, -7).

• Metrics/cptMetrics_bas.bas: 6
• cptSetup_bas.bas: 4
• Status/cptTaskHistory_bas.bas: 3
• Metrics/cptDECM_frm.frm: 3
• Metrics/cptDECM_bas.bas: 3

Todo:

• assign this issue
• label the issue for enhancement or bug
• label the issue with codemodule (so fixes can be aggregated and hotfixed together)
• checkout appropriate branch and create topic branch
• design, code and test
• update codemodule <cpt_version>x.y.z</cpt_version>
• update CurrentVersions.xml manually
• commit changes prefix comment with Issue #XXX -
• merge topic into appropriate branch(es) and push
• delete topic branch

[AronGahagan]

• Are there any calculations, anywhere, that assume 7 days between "weeks" or "periods"?

[AronGahagan]

• Are there any calculations, anywhere, that assume 7 days between "weeks" or "periods"?

No, none that matter.

[AronGahagan]

• ensure nothing else is 'filling in the gaps' for prettier charting. Axis type should be "text" not "date."

[AronGahagan]

...incorrect. The following (at least) are assuming status periods are weekly:

$ git grep -E "(dtStatus.*7|\bdt*Week\b)"
# also check git grep -E "\bdt[A-Z][a-z]+\b"

Metrics/cptMetrics_bas.bas:    lngLastRow = oWorksheet.Columns(1).Find(DateAdd("d", 6 - Weekday(dtStatus) - 7, dtStatus)).Row 'requires matching date format
Metrics/cptMetrics_bas.bas:  Dim dtWeek As Date
Metrics/cptMetrics_bas.bas:      dtWeek = dtMin
Metrics/cptMetrics_bas.bas:      Do While dtWeek <= dtMax
Metrics/cptMetrics_bas.bas:        dtWeek = DateAdd("d", 7, dtWeek)
Metrics/cptMetrics_bas.bas:        strMissingWeeks = strMissingWeeks & dtWeek & ","
Metrics/cptMetrics_bas.bas:        oWorksheet.Cells(lngES, 7) = DateAdd("d", 6 - Weekday(dtStatus) - 7, dtStatus)
Metrics/cptMetrics_bas.bas:      cptCaptureMetric strProgram, CDate(dtStatus & " 05:00 PM"), "ES", CDate(FormatDateTime(oWorksheet.Cells(lngES + 16, 7).Value, vbShortDate))
ResourceDemand/cptResourceDemand_bas.bas:  Dim dtWeek As Date
ResourceDemand/cptResourceDemand_bas.bas:                  dtWeek = DateAdd("d", 2 - Weekday(oTSV.StartDate), oTSV.StartDate) 'DateAdd("d", 1, dtWeek)
ResourceDemand/cptResourceDemand_bas.bas:                  dtWeek = DateAdd("d", 6 - Weekday(oTSV.StartDate), oTSV.StartDate) 'DateAdd("d", -2, dtWeek)
ResourceDemand/cptResourceDemand_bas.bas:                  dtWeek = DateAdd("d", 7 - Weekday(oTSV.StartDate), oTSV.StartDate) 'DateAdd("d", -1, dtWeek)
ResourceDemand/cptResourceDemand_bas.bas:            strRecord = strRecord & FormatDateTime(dtWeek, vbShortDate) & "," 'week
ResourceDemand/cptResourceDemand_bas.bas:                    'dtWeek = tsv.StartDate
ResourceDemand/cptResourceDemand_bas.bas:                      dtWeek = DateAdd("d", 2 - Weekday(oTSV.StartDate), oTSV.StartDate) 'DateAdd("d", 1, dtWeek)
ResourceDemand/cptResourceDemand_bas.bas:                    'dtWeek = tsv.EndDate
ResourceDemand/cptResourceDemand_bas.bas:                      dtWeek = DateAdd("d", 6 - Weekday(oTSV.StartDate), oTSV.StartDate) 'DateAdd("d", -2, dtWeek)
ResourceDemand/cptResourceDemand_bas.bas:                      dtWeek = DateAdd("d", 7 - Weekday(oTSV.StartDate), oTSV.StartDate) 'DateAdd("d", -1, dtWeek)
ResourceDemand/cptResourceDemand_bas.bas:                strRecord = strRecord & FormatDateTime(dtWeek, vbShortDate) & "," 'week

# this probably focuses the effort a bit:
$ git grep -E "dt[A-Z][a-z]+.*\b7"

Calendar/cptCalendarExceptions_bas.bas:                  dtDate = DateAdd("d", 7 + .MonthItem - 2 - Weekday(dtDate), dtDate)
Calendar/cptCalendarExceptions_bas.bas:                  dtDate = DateAdd("d", 7 * .MonthPosition, dtDate)
Calendar/cptCalendarExceptions_bas.bas:                  dtDate = DateAdd("d", 7 + .MonthItem - 2 - Weekday(dtDate), dtDate)
Calendar/cptCalendarExceptions_bas.bas:                  dtDate = DateAdd("d", 7 * .MonthPosition, dtDate)
Calendar/cptCalendarExceptions_bas.bas:                    dtDate = DateAdd("d", 7 * .Period, dtDate)
Calendar/cptCalendarExceptions_bas.bas:            dtDate = DateAdd("d", 7 + .MonthItem - 2 - Weekday(dtDate), dtDate)
Calendar/cptCalendarExceptions_bas.bas:            dtDate = DateAdd("d", 7 * .MonthPosition, dtDate)
Calendar/cptCalendarExceptions_bas.bas:            dtDate = DateAdd("d", 7 + .MonthItem - 2 - Weekday(dtDate), dtDate)
Calendar/cptCalendarExceptions_bas.bas:            dtDate = DateAdd("d", 7 * .MonthPosition, dtDate)
Calendar/cptCalendarExceptions_bas.bas:              dtDate = DateAdd("d", 7 * .Period, dtDate)
Metrics/cptMetrics_bas.bas:    dtDate = DateAdd("d", 7, dtDate)
Metrics/cptMetrics_bas.bas:    lngLastRow = oWorksheet.Columns(1).Find(DateAdd("d", 6 - Weekday(dtStatus) - 7, dtStatus)).Row 'requires matching date format
Metrics/cptMetrics_bas.bas:  dtNextWeek = DateAdd("d", 7, dtThisWeek)
Metrics/cptMetrics_bas.bas:        dtWeek = DateAdd("d", 7, dtWeek)
Metrics/cptMetrics_bas.bas:        oWorksheet.Cells(lngES, 7) = DateAdd("d", 6 - Weekday(dtStatus) - 7, dtStatus)
Metrics/cptMetrics_bas.bas:      cptCaptureMetric strProgram, CDate(dtStatus & " 05:00 PM"), "ES", CDate(FormatDateTime(oWorksheet.Cells(lngES + 16, 7).Value, vbShortDate))
ResourceDemand/cptResourceDemand_bas.bas:                  dtWeek = DateAdd("d", 7 - Weekday(oTSV.StartDate), oTSV.StartDate) 'DateAdd("d", -1, dtWeek)
ResourceDemand/cptResourceDemand_bas.bas:                      dtWeek = DateAdd("d", 7 - Weekday(oTSV.StartDate), oTSV.StartDate) 'DateAdd("d", -1, dtWeek)
arongahagan@CP-LT-CD24260RB UCRT64 :/c/Users/AronGahagan/GitHub/cpt (develop ±)
$ git grep dtLastWeek
Metrics/cptMetrics_bas.bas:  Dim dtLastWeek As Date
Metrics/cptMetrics_bas.bas:    dtLastWeek = oRecordset("STATUS_DATE")
Metrics/cptMetrics_bas.bas:    strMsg = strMsg & "Previous Status Date: " & FormatDateTime(dtLastWeek, vbShortDate) & vbCrLf
Metrics/cptMetrics_bas.bas:    oRecordset.Filter = "PROJECT='" & strProgram & "' AND STATUS_DATE=#" & FormatDateTime(dtLastWeek, vbGeneralDate) & "#"
Metrics/cptMetrics_bas.bas:      MsgBox "No data found for WE " & FormatDateTime(dtLastWeek, vbShortDate), vbExclamation + vbOKOnly, "No Data"
Metrics/cptMetrics_bas.bas:        If oRecordset("PROJECT") = strProgram And oRecordset("TASK_FINISH") > dtLastWeek And oRecordset("TASK_FINISH") <= dtThisWeek And oRecordset("TASK_AF") = 0 Then