-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
arithmetic-circuit/R1CSTask related to the R1CS programsTask related to the R1CS programsc++Task related to the c++ part of the code baseTask related to the c++ part of the code basecode-qualityTask related to the code quality (refactor, enhancements etc.)Task related to the code quality (refactor, enhancements etc.)
Description
So far, we have followed a "public inheritance" approach when inheriting from the libsnark::gadget class and set the right scopes on the class' attributes and methods. However, the aggregator_gadget inherits privately from gadget which contrasts with the approach just mentioned (following public inheritance), see: https://clearmatics.github.io/zecale/inherits.html for illustration.
This inconsistency needs to either:
- Be fixed, or
- Be documented (if justified)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
arithmetic-circuit/R1CSTask related to the R1CS programsTask related to the R1CS programsc++Task related to the c++ part of the code baseTask related to the c++ part of the code basecode-qualityTask related to the code quality (refactor, enhancements etc.)Task related to the code quality (refactor, enhancements etc.)