diff --git a/R/reduce_rank_regression.R b/R/reduce_rank_regression.R index c9c7cfd..6fbbae6 100644 --- a/R/reduce_rank_regression.R +++ b/R/reduce_rank_regression.R @@ -1,5 +1,5 @@ reduce_rank_regression <- function(x, y, gamma_matrix, rank = "full", k = 0){ - full_rank <- min(dim(x)[2], dim(y)[2]) + full_rank <- dim(y)[2] if(rank == "full"){ reduce_rank <- full_rank } else if(rank <= full_rank){ diff --git a/R/rrr.R b/R/rrr.R index d53673b..a6ce5b4 100644 --- a/R/rrr.R +++ b/R/rrr.R @@ -45,7 +45,7 @@ rrr <- function(x, y, type = "identity", rank = "full", k = 0){ if(type == "lda"){ full_rank <- dim(distinct(as_data_frame(y)))[1] - 1 } else { - full_rank <- min(dim(x)[2], dim(y)[2]) + full_rank <- dim(y)[2] } if(rank == "full"){ reduced_rank <- full_rank @@ -99,7 +99,7 @@ rrr <- function(x, y, type = "identity", rank = "full", k = 0){ #' @export rank_trace <- function(x, y, type = "identity", k = 0, plot = TRUE, interactive = FALSE){ - ident <- diag(1, min(dim(x)[2], dim(y)[2])) + ident <- diag(1, dim(y)[2]) switch(type, identity = rrr_rank_trace(x, y, ident, k, plot, interactive), cva = cva_rank_trace(x, y, k, plot, interactive), @@ -138,7 +138,7 @@ rank_trace <- function(x, y, type = "identity", k = 0, plot = TRUE, interactive #' @export residuals <- function(x, y, type = "identity", rank = "full", k = 0, plot = TRUE){ - ident <- diag(1, min(dim(x)[2], dim(y)[2])) + ident <- diag(1, dim(y)[2]) switch(type, identity = rrr_residual_plot(x, y, ident, rank, k, plot), cva = cva_residual_plot(x, y, rank, k, plot),