Merge pull request #6 from chamika/copilot/sub-pr-5

Fix review feedback: remove unused imports and redundant test conditions

Author: chamika

worker/package-lock.json

@@ -13,7 +13,7 @@ INSERT INTO teams (id, name, elttl_url, created_at, updated_at)
 VALUES (
   '00000000-0000-0000-0000-000000000000',
   'Test Team E2E',
-  'https://www.elttl.co.uk/Availability.aspx?FixtureId=0&TeamId=999',
+  'https://elttl.interactive.co.uk/teams/view/999',
   strftime('%s', 'now'),
   strftime('%s', 'now')
 );

worker/seed.sql

@@ -1,4 +1,4 @@
-import { describe, it, expect, beforeEach, afterEach } from 'vitest';
+import { describe, it, expect, beforeEach } from 'vitest';
 import { DatabaseService } from './database';
 
 // Note: These are integration tests that require a real D1 database instance

worker/src/database.integration.test.ts

@@ -1,5 +1,5 @@
 import type { Env, Team, Fixture, Player, Availability, FinalSelection } from './types';
-import { generateUUID, now, isPastDate, getAvailabilityKey } from './utils';
+import { generateUUID, now, isPastDate } from './utils';
 
 /**
  * Database service for D1 operations

worker/src/database.ts

@@ -225,9 +225,7 @@ describe('Player Summary Calculations', () => {
 		const gamesScheduled = 3;
 		const totalGames = gamesPlayed + gamesScheduled; // 8
 
-		const selectionRate = totalGames > 0 
-			? Math.round((gamesScheduled / totalGames) * 100) 
-			: 0;
+		const selectionRate = Math.round((gamesScheduled / totalGames) * 100);
 
 		expect(selectionRate).toBe(38); // 3/8 = 37.5% rounds to 38%
 	});
@@ -244,13 +242,10 @@ describe('Player Summary Calculations', () => {
 	});
 
 	it('should calculate 100% selection rate', () => {
-		const gamesPlayed = 0;
 		const gamesScheduled = 5;
-		const totalGames = gamesScheduled;
+		const totalGames = 5;
 
-		const selectionRate = totalGames > 0 
-			? Math.round((gamesScheduled / totalGames) * 100) 
-			: 0;
+		const selectionRate = Math.round((gamesScheduled / totalGames) * 100);
 
 		expect(selectionRate).toBe(100);
 	});