Changes to Ecobee Authentication

[livitup]

Ecobee is changing their authentication protocols as documented here:

https://www.ecobee.com/home/developer/api/documentation/v1/auth/developer-migration-summary.shtml

I suspect this will break promobee, and the @jamesmulcahy pull.

Before starting my own work on this and creating a third pull, I wanted to reach out to you both and see if you cared to handle this.

[jamesmulcahy]

@livitup I don't have cycles for this myself right now, and authentication APIs have never really been my thing either. If you're willing to have a go at this, I'd certainly appreciate it.

[livitup]

@jamesmulcahy I started to dig into the code, but December 1 rolled around and I hadn't really figured out what to change - meanwhile everything is still working fine, so I think this can be closed as a false alarm. From what I understood of the notice from Ecobee it was a change in the length/format of the token, so code that was limiting the size/length/format/etc. of the token variable would break. Suspect promobee just stuffs it in a string, so everything should be good to go.

[mgaudet]

It appears this potentially still broken;

I just tried re-registering promobee with a new API key and:

pi@raspberrypi:~/tools/promobee/obj $ ./promobee --api_key <KEY> --store credentials  register
Register with this PIN: XXXX-XXXX
Press any key to continue when done.

failed decoding authentication response: invalid character '<' looking for beginning of value

[livitup]

Bad news. The tokens were changed to include non alpha-numeric characters, so this does, indeed look like it would block new registrations. I didn't think of the difference between existing and new registrations.

It looks like the token processing code in promobee is actually inherited from one of the author's other projects: https://github.com/cfunkhouser/egobee I don't have time to start digging through that code right now, but I'll try to come back to it if nobody beats me to it.