Skip to content

extract computeRoot to a separate method #261

@rach-id

Description

@rach-id
          I think this was simpler because `computeRoot` also operates on a few vars inside of the scope of the wrapping method (e.g. `subtreeRoots`). I think this was an optimization wrt to the recursive calls. I would merge as is but if benchmarks and readability improve or stay the same, I would not mind Evan's suggestion in a followup PR.

Originally posted by @liamsi in #260 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions