From c0a2bf57ef77d461110a97de97d80692d0de170e Mon Sep 17 00:00:00 2001 From: Vlad <13818348+walldiss@users.noreply.github.com> Date: Thu, 19 Feb 2026 16:02:05 +0100 Subject: [PATCH] ci: remove setup job and fix debug flag propagation The setup job was broken: it wrote to $GITHUB_ENV instead of $GITHUB_OUTPUT, so the debug flag never reached other jobs. It also compared runner.debug to "true" when the actual value is "1". Remove the job entirely and evaluate runner.debug inline in each step that needs it, removing ~30s of startup latency from all downstream jobs. --- .github/workflows/go-ci.yml | 26 +++----------------------- 1 file changed, 3 insertions(+), 23 deletions(-) diff --git a/.github/workflows/go-ci.yml b/.github/workflows/go-ci.yml index cd42aa39e..ad83afa26 100644 --- a/.github/workflows/go-ci.yml +++ b/.github/workflows/go-ci.yml @@ -13,23 +13,7 @@ concurrency: cancel-in-progress: true jobs: - setup: - name: Setup - runs-on: ubuntu-latest - outputs: - debug: ${{ steps.debug.outputs.debug }} - steps: - - name: Set debug output - id: debug - run: | - if [[ "${{ runner.debug }}" == "true" ]]; then - echo "debug=true" >> $GITHUB_ENV - else - echo "debug=false" >> $GITHUB_ENV - fi - lint: - needs: [setup] name: Lint runs-on: ubuntu-latest @@ -47,7 +31,6 @@ jobs: version: latest lint-imports: - needs: [setup] name: Lint Imports runs-on: ubuntu-latest @@ -65,7 +48,6 @@ jobs: run: make lint-imports go_mod_tidy_check: - needs: [setup] name: Go Mod Tidy Check runs-on: ubuntu-latest @@ -86,7 +68,6 @@ jobs: run: git diff --exit-code go_mod_parity_check: - needs: [setup] name: Go Mod Parity Check runs-on: ubuntu-latest @@ -101,7 +82,6 @@ jobs: run: ./scripts/check-go-mod-parity.sh test_coverage: - needs: [setup] name: Unit Tests Coverage strategy: fail-fast: false @@ -120,11 +100,11 @@ jobs: go-version: ${{ inputs.go-version }} - name: run unit tests - run: make test-unit ENABLE_VERBOSE=${{ needs.setup.outputs.debug }} + run: make test-unit ENABLE_VERBOSE=${{ runner.debug == '1' && 'true' || 'false' }} - name: Upload unit test output uses: actions/upload-artifact@v4 - if: always() && needs.setup.outputs.debug == 'true' + if: always() && runner.debug == '1' with: name: unit-test-output-${{ matrix.os }} path: | @@ -160,7 +140,7 @@ jobs: # go-version: ${{ inputs.go-version }} # - name: execute test run - # run: make test-unit-race ENABLE_VERBOSE=${{ needs.setup.outputs.debug }} + # run: make test-unit-race ENABLE_VERBOSE=${{ runner.debug == '1' && 'true' || 'false' }} integration_test: name: Integration Tests