Skip to content

Features/notooltipifchildren #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AAAnthonyAAA merged 2 commits into from
Jan 30, 2026
Merged

Features/notooltipifchildren #76

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75a567b
feat(NavItemButton): no tooltip if children
SuperChuck83 Jan 30, 2026
fbc2adb
feat(NavItemButton): no tooltip if children release note
SuperChuck83 Jan 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@cegid/vsb-cds-react",
"version": "1.23.9",
"version": "1.24.0",
"description": "BAAM! Design System by Cegid - React component library",
"main": "dist/index.cjs.js",
"module": "dist/index.es.js",
Expand Down
2 changes: 1 addition & 1 deletion src/components/NavigationBar/NavItemButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ const NavItemButton: React.FC<NavItemButtonProps> = ({
const handleMouseEnter = () => {
setIsHovered(true);
// Only show tooltip if navigation is collapsed (text is not visible)
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment should be updated to reflect the new condition. Consider updating it to "Only show tooltip if navigation is collapsed (text is not visible) and item has no children (since children are shown in sidebar)"

Suggested change
// Only show tooltip if navigation is collapsed (text is not visible)
// Only show tooltip if navigation is collapsed (text is not visible) and item has no children (since children are shown in sidebar)

Copilot uses AI. Check for mistakes.
if (!isExpanded) {
if (!isExpanded && !hasChildren ) {
Copy link

Copilot AI Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a spacing issue before the closing parenthesis. Remove the extra space before the closing parenthesis for consistent code formatting.

Copilot uses AI. Check for mistakes.
tooltipTimer.current = window.setTimeout(() => {
setShowTooltip(true);
}, 200);
Expand Down
10 changes: 10 additions & 0 deletions src/stories/ReleaseNotes.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,16 @@ interface ReleaseNote {
}

const releaseNotes: ReleaseNote[] = [
{
version: "1.24.0",
changes: [
{
component: "NavItemButton",
type: "enhancement",
description: "no tooltip if children",
}
],
},
{
version: "1.23.9",
changes: [
Expand Down
Loading