folding

[laurentpetit]

Original issue 63 created by laurentpetit on 2010-03-11T10:14:02.000Z:

please add folding of at least defn-s

[laurentpetit]

Comment #1 originally posted by laurentpetit on 2010-03-18T11:04:26.000Z:

<empty>

[laurentpetit]

Comment #2 originally posted by laurentpetit on 2010-04-18T20:56:27.000Z:

<empty>

[laurentpetit]

Comment #3 originally posted by laurentpetit on 2011-04-21T19:28:27.000Z:

<empty>

[laurentpetit]

Comment #4 originally posted by laurentpetit on 2011-10-03T11:16:32.000Z:

<empty>

[laurentpetit]

Comment #5 originally posted by laurentpetit on 2011-10-06T11:12:05.000Z:

<empty>

[laurentpetit]

Comment #6 originally posted by laurentpetit on 2011-12-30T21:20:04.000Z:

<empty>

[laurentpetit]

Comment #7 originally posted by laurentpetit on 2012-01-17T23:05:47.000Z:

<empty>

[laurentpetit]

Comment #8 originally posted by laurentpetit on 2012-06-21T15:11:24.000Z:

hi!
i tried to implement the folding for ccw.
the first and very draft version :)
http://idobela.at.tut.by/img/eclipse-ccw-folding.png

created CcwReconcilingStrategy (inited in ClojureSourceViewerConfiguration.getReconciler) which do rescan of the whole document and emits Positions of all top-level sexpr.

what i want/have todo:

• investigate more intelligent way of parsing (to scan only changed part of the document)
• extend of folding a little deeper (to some constructs like "let" "if" "fn")

[laurentpetit]

Comment #9 originally posted by laurentpetit on 2012-06-24T20:13:06.000Z:

Great !

Do you have the code available somewhere for review ?

My guess, if I understand correctly what you've written, is that you may have worked a little bit too hard reinventing what can already be deduced from existing information.

E.G. : for the syntax coloration, and the auto-indenter, etc., there's already a model of the parse tree of the source code, for each editor, available and up-to-date.

Meaning you can already benefit from incremental updates to the parser.

For instance, there's the DamageRepairer which already takes care of only "marking" damaged the top level forms surrounding the text "edit".

So the list of top level forms is already there, in the parse tree: on just has to browse the tree to find the interesting parts.

Of course, in an ideal world, the code to reuse would be in a good shape ... and I dont' know if it is without further investigation.

Maybe if you can share what you already have, I can take a look at it next thursday, and indicate ways to improve it by showing examples of reuse of the existing.
It will also maybe force me to refactor the existing code a little bit, but that's for the greater good, so I'm not reluctant do doing it!

Thanks for contributing !

Laurent

[laurentpetit]

Comment #10 originally posted by laurentpetit on 2012-06-25T15:02:19.000Z:

Yes, you are right, my code is simple, not optimal and not-using existing in CCW utils: it just searches for "(" and skips ";".
I tried to use ClojureEditor.getTopLevelSExpression()

I'd like to know how can I re-use the incremental parsing and already built AST.

Tommorow I'll send the changed files.

[laurentpetit]

Comment #11 originally posted by laurentpetit on 2012-06-25T15:56:52.000Z:

Hi,

Oh indeed, ClojureEditor.getTopLevelSExpression() is something that existed before the incremental parser, and since the parser was introduced, it has not been removed/refactored.

I'll be able to answer you by thursday (with the help of what you've already done, so I'll be able to play with your prototype).

Cheers