From cc7184785ece3885ca5accef33e5ac199bccfc74 Mon Sep 17 00:00:00 2001
From: cct0831 <cct0831github@gmail.com>
Date: Fri, 20 Mar 2026 22:51:23 +0800
Subject: [PATCH] refactor(core): collection expressions for Analysis DTOs and
 BasePagedListVM
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Replace `new List<T>()` property initializers with `[]` collection expressions:
- AnalysisQueryRequest: Dimensions, Measures, Filters
- AnalysisQueryResponse: Columns, Rows
- ServerSideGroupByStrategy: empty list returns
- BasePagedListVM: Ids

First batch — remaining files deferred to follow-up.

Closes #700 (partial)

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 src/WalkingTec.Mvvm.Core/Analysis/AnalysisQueryRequest.cs   | 6 +++---
 src/WalkingTec.Mvvm.Core/Analysis/AnalysisQueryResponse.cs  | 4 ++--
 .../Analysis/ServerSideGroupByStrategy.cs                   | 4 ++--
 src/WalkingTec.Mvvm.Core/BasePagedListVM.cs                 | 2 +-
 4 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/src/WalkingTec.Mvvm.Core/Analysis/AnalysisQueryRequest.cs b/src/WalkingTec.Mvvm.Core/Analysis/AnalysisQueryRequest.cs
index b234e877a..c932013a5 100644
--- a/src/WalkingTec.Mvvm.Core/Analysis/AnalysisQueryRequest.cs
+++ b/src/WalkingTec.Mvvm.Core/Analysis/AnalysisQueryRequest.cs
@@ -15,13 +15,13 @@ public class AnalysisQueryRequest
         public string? SearcherFormData { get; set; }
 
         /// <summary>選取的維度欄位名稱（最多 3 個）。</summary>
-        public List<string> Dimensions { get; set; } = new List<string>();
+        public List<string> Dimensions { get; set; } = [];
 
         /// <summary>選取的度量及聚合函式。</summary>
-        public List<MeasureRequest> Measures { get; set; } = new List<MeasureRequest>();
+        public List<MeasureRequest> Measures { get; set; } = [];
 
         /// <summary>額外過濾條件（白名單驗證後進 Expression Tree）。</summary>
-        public List<FilterCondition> Filters { get; set; } = new List<FilterCondition>();
+        public List<FilterCondition> Filters { get; set; } = [];
 
         /// <summary>維度對應的日期階層（僅日期維度需要，key=fieldName, value=hierarchy）</summary>
         public Dictionary<string, DateHierarchy>? DimensionHierarchies { get; set; }
diff --git a/src/WalkingTec.Mvvm.Core/Analysis/AnalysisQueryResponse.cs b/src/WalkingTec.Mvvm.Core/Analysis/AnalysisQueryResponse.cs
index 6244f23be..a40585583 100644
--- a/src/WalkingTec.Mvvm.Core/Analysis/AnalysisQueryResponse.cs
+++ b/src/WalkingTec.Mvvm.Core/Analysis/AnalysisQueryResponse.cs
@@ -9,10 +9,10 @@ namespace WalkingTec.Mvvm.Core.Analysis
     public class AnalysisQueryResponse
     {
         /// <summary>欄位名稱清單（有序，對應 Rows 中的 key）。</summary>
-        public List<string> Columns { get; set; } = new List<string>();
+        public List<string> Columns { get; set; } = [];
 
         /// <summary>資料列（每列為 欄位名→值 的字典）。</summary>
-        public List<Dictionary<string, object?>> Rows { get; set; } = new List<Dictionary<string, object?>>();
+        public List<Dictionary<string, object?>> Rows { get; set; } = [];
 
         /// <summary>GroupBy 後總筆數。</summary>
         public int TotalCount { get; set; }
diff --git a/src/WalkingTec.Mvvm.Core/Analysis/ServerSideGroupByStrategy.cs b/src/WalkingTec.Mvvm.Core/Analysis/ServerSideGroupByStrategy.cs
index cef23b598..c92e577cd 100644
--- a/src/WalkingTec.Mvvm.Core/Analysis/ServerSideGroupByStrategy.cs
+++ b/src/WalkingTec.Mvvm.Core/Analysis/ServerSideGroupByStrategy.cs
@@ -26,7 +26,7 @@ public class ServerSideGroupByStrategy : IGroupByStrategy
             CancellationToken cancellationToken = default)
         {
             if (req.Dimensions.Count == 0)
-                return new List<Dictionary<string, object?>>();
+                return [];
 
             if (req.DimensionHierarchies != null && req.Dimensions.Any(d => req.DimensionHierarchies.TryGetValue(d, out var h) && h != DateHierarchy.None))
             {
@@ -51,7 +51,7 @@ public class ServerSideGroupByStrategy : IGroupByStrategy
             CancellationToken cancellationToken = default)
         {
             if (req.Dimensions.Count == 0)
-                return new List<Dictionary<string, object?>>();
+                return [];
 
             if (req.DimensionHierarchies != null && req.Dimensions.Any(d => req.DimensionHierarchies.TryGetValue(d, out var h) && h != DateHierarchy.None))
             {
diff --git a/src/WalkingTec.Mvvm.Core/BasePagedListVM.cs b/src/WalkingTec.Mvvm.Core/BasePagedListVM.cs
index 992100a06..13d152ccd 100644
--- a/src/WalkingTec.Mvvm.Core/BasePagedListVM.cs
+++ b/src/WalkingTec.Mvvm.Core/BasePagedListVM.cs
@@ -423,7 +423,7 @@ public SortInfo CreateSortInfo(Expression<Func<TModel, object>> pro, SortDir dir
         /// <summary>
         ///记录批量操作时列表中选择的Id
         /// </summary>
-        public List<string> Ids { get; set; } = new List<string>();
+        public List<string> Ids { get; set; } = [];
         public string? SelectorValueField { get; set; }
         /// <summary>
         /// 是否已经搜索过