-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Labels
bugSomething isn't workingSomething isn't workingin-progressWork currently in progressWork currently in progress
Description
Summary
Recent analysis saved-query endpoints bypass VM role checks.
Evidence
- Commit
ebbb515469ade20dfaa1ea29121ffd5d156876f5(merge of PR feat(analysis): Analysis Mode Saved Queries CRUD #684) introduced saved-query CRUD paths. - In
src/WalkingTec.Mvvm.Mvc/_AnalysisController.cs, methodsListSavedQueries,SaveQuery, andGetSavedQuerydid not enforceCheckAccess(vmType). - Secure analysis query paths already enforce RBAC in
TryPrepareContext.
Risk
Users without required AllowedRoles can list/save/load saved queries for restricted VM types (including public saved queries).
Proposed minimal fix
- Add
Resolve + CheckAccessinListSavedQueriesandSaveQuery. - In
GetSavedQuery, deserialize config thenResolve + CheckAccessbefore returning config. - Add regression tests for 403 behavior on restricted VM.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingin-progressWork currently in progressWork currently in progress