Skip to content

sigma_a computation for binomial #2

@seekshreyas

Description

@seekshreyas

Hi @cbellei,

Thanks for an amazing load of work here. Really impressive.

While going over the code I saw this:

sigma_a_rvs = np.sqrt(a_rvs * (1 - a_rvs))
sigma_b_rvs = np.sqrt(b_rvs * (1 - b_rvs))

at: https://github.com/cbellei/abyes/blob/master/abyes/ab_exp.py#L148

Shouldn't the n_a in the formula as well?
As for binomial distribution
standard deviation (σx) is sqrt[ n * P * ( 1 - P ) ].

Thanks in advance. I'm happy to send a PR, but wanted to check first if I'm correct.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions