PHPUnit tests failing in Moodle 5.1 #105
Description
Description
Running the tool_emailutils_testsuite on Moodle 5.1+ with PHP 8.4 and PHPUnit 11.5 results in 13 errors and 1 deprecation warning.
All test errors are caused by the removed MockBuilder::setMethods() API in PHPUnit 10+.
Stack Trace
vendor/bin/phpunit --testsuite tool_emailutils_testsuite
Moodle 5.1+ (Build: 20251127)
Php: 8.4.16, mysqli: 8.4.8, OS: Linux 6.8.0-101-generic x86_64
PHPUnit 11.5.12 by Sebastian Bergmann and contributors.
Runtime: PHP 8.4.16
Configuration: /var/www/moodle-upgrade/phpunit.xml
SD.......EEEEEEEEEEEEE.. 24 / 24 (100%)
Time: 00:03.492, Memory: 88.50 MB
There were 13 errors:
1) tool_emailutils\suffix_test::test_suffix with data set "no subdomain" ('client.com', 'client.com', 'client.com', '')
Error: Call to undefined method PHPUnit\Framework\MockObject\MockBuilder::setMethods()
/var/www/moodle-upgrade/public/admin/tool/emailutils/tests/suffix_test.php:43
2) tool_emailutils\suffix_test::test_suffix with data set "subdomain" ('lms.client.com', 'client.com', 'client.com', 'lms')
Error: Call to undefined method PHPUnit\Framework\MockObject\MockBuilder::setMethods()
/var/www/moodle-upgrade/public/admin/tool/emailutils/tests/suffix_test.php:43
3) tool_emailutils\suffix_test::test_suffix with data set "another subdomain" ('moodle.client.com', 'client.com', 'client.com', 'moodle')
Error: Call to undefined method PHPUnit\Framework\MockObject\MockBuilder::setMethods()
/var/www/moodle-upgrade/public/admin/tool/emailutils/tests/suffix_test.php:43
4) tool_emailutils\suffix_test::test_suffix with data set "multiple subdomain" ('lms.moodle.client.com', 'client.com', 'client.com', 'lms-moodle')
Error: Call to undefined method PHPUnit\Framework\MockObject\MockBuilder::setMethods()
/var/www/moodle-upgrade/public/admin/tool/emailutils/tests/suffix_test.php:43
5) tool_emailutils\suffix_test::test_suffix with data set "longer tld" ('lms.moodle.client.nsw.gov.au', 'client.nsw.gov.au', 'client.nsw.gov.au', 'lms-moodle')
Error: Call to undefined method PHPUnit\Framework\MockObject\MockBuilder::setMethods()
/var/www/moodle-upgrade/public/admin/tool/emailutils/tests/suffix_test.php:43
6) tool_emailutils\suffix_test::test_suffix with data set "www only subdomain" ('www.client.com', 'client.com', 'client.com', '')
Error: Call to undefined method PHPUnit\Framework\MockObject\MockBuilder::setMethods()
/var/www/moodle-upgrade/public/admin/tool/emailutils/tests/suffix_test.php:43
7) tool_emailutils\suffix_test::test_suffix with data set "www multiple subdomain" ('www.moodle.client.com', 'client.com', 'client.com', 'moodle')
Error: Call to undefined method PHPUnit\Framework\MockObject\MockBuilder::setMethods()
/var/www/moodle-upgrade/public/admin/tool/emailutils/tests/suffix_test.php:43
8) tool_emailutils\suffix_test::test_suffix with data set "different subdomain" ('lms.client.com', 'mail.client.com', 'client.com', 'lms')
Error: Call to undefined method PHPUnit\Framework\MockObject\MockBuilder::setMethods()
/var/www/moodle-upgrade/public/admin/tool/emailutils/tests/suffix_test.php:43
9) tool_emailutils\suffix_test::test_suffix with data set "noreply contains part of subdomain" ('lms.moodle.client.com', 'moodle.client.com', 'client.com', 'lms')
Error: Call to undefined method PHPUnit\Framework\MockObject\MockBuilder::setMethods()
/var/www/moodle-upgrade/public/admin/tool/emailutils/tests/suffix_test.php:43
10) tool_emailutils\suffix_test::test_suffix with data set "noreply subdomain of lms" ('lms.moodle.client.com', 'email.lms.moodle.client.com', 'client.com', '')
Error: Call to undefined method PHPUnit\Framework\MockObject\MockBuilder::setMethods()
/var/www/moodle-upgrade/public/admin/tool/emailutils/tests/suffix_test.php:43
11) tool_emailutils\suffix_test::test_suffix with data set "unable to identify primary domain" ('lms.moodle.client.com', 'client.com', 'lms.moodle.client.com', 'lms-moodle')
Error: Call to undefined method PHPUnit\Framework\MockObject\MockBuilder::setMethods()
/var/www/moodle-upgrade/public/admin/tool/emailutils/tests/suffix_test.php:43
12) tool_emailutils\suffix_test::test_suffix with data set "different noreply" ('lms.moodle.client.com', 'vendor.com', 'client.com', 'lms-moodle-client-com')
Error: Call to undefined method PHPUnit\Framework\MockObject\MockBuilder::setMethods()
/var/www/moodle-upgrade/public/admin/tool/emailutils/tests/suffix_test.php:43
13) tool_emailutils\suffix_test::test_suffix with data set "different noreply with no subdomain" ('client.com', 'vendor.com', 'client.com', 'client-com')
Error: Call to undefined method PHPUnit\Framework\MockObject\MockBuilder::setMethods()
/var/www/moodle-upgrade/public/admin/tool/emailutils/tests/suffix_test.php:43
--
1 test triggered 1 PHP deprecation:
1) /var/www/moodle-upgrade/public/admin/tool/emailutils/lib/aws-sns-message-validator/src/MessageValidator.php:64
Aws\Sns\MessageValidator::__construct(): Implicitly marking parameter $certClient as nullable is deprecated, the explicit nullable type must be used instead
Triggered by:
* tool_emailutils\sns_client_test::test_lib
/var/www/moodle-upgrade/public/admin/tool/emailutils/tests/sns_client_test.php:43
ERRORS!
Tests: 24, Assertions: 52, Errors: 13, Deprecations: 1, PHPUnit Deprecations: 7, Skipped: 1.