-
Notifications
You must be signed in to change notification settings - Fork 0
Open
Description
Description:
Several classes exceed the recommended 300-line limit, making them harder to maintain and test.
Large Classes Identified:
- ModernPOSActivity.kt: 381 lines
- PaymentRequestActivity.kt: 852 lines
- TopUpActivity.kt: 562 lines
- Other activities likely affected
Issues:
- Violates Single Responsibility Principle
- Harder to test individual components
- Increased complexity for maintenance
Fix Instructions:
Break down large classes using these patterns:
- Extract Helper Classes:
// Extract complex logic to separate classes
class PaymentFlowManager(private val activity: PaymentRequestActivity) {
fun handlePaymentFlow() { /* logic */ }
}- Use Fragments for UI Components:
// Split large activities into fragments
class PaymentOptionsFragment : Fragment()
class PaymentStatusFragment : Fragment() - Extract Business Logic:
// Move business logic to separate classes
class PaymentProcessor
class ValidationManagerRefactoring Priority:
- PaymentRequestActivity.kt (852 lines) - highest priority
- TopUpActivity.kt (562 lines)
- ModernPOSActivity.kt (381 lines)
Target: Keep classes under 300 lines, methods under 50 lines
Metadata
Metadata
Assignees
Labels
No labels