From 14265e3452b5fb355564f1f3fdca6bc0a72f64a7 Mon Sep 17 00:00:00 2001 From: Adrian Dombeck Date: Mon, 9 Feb 2026 22:59:07 +0100 Subject: [PATCH] Revert "gh-actions/build-debian: Run licenserecon" Turns out that lintian already checks the licenses and it's really the issues found by lintian which we care about (at least that is what reviewers of uploads to the archive look at). We just have to make the build-debian action fail when lintian fails (done in #100) and pass `--fail-on error,warning` to lintian (possible via the `lintian` input). --- .github/workflows/test-build-deb.yaml | 4 ++-- gh-actions/common/build-debian/action.yaml | 26 ---------------------- 2 files changed, 2 insertions(+), 28 deletions(-) diff --git a/.github/workflows/test-build-deb.yaml b/.github/workflows/test-build-deb.yaml index 0447158b..b822f342 100644 --- a/.github/workflows/test-build-deb.yaml +++ b/.github/workflows/test-build-deb.yaml @@ -42,7 +42,7 @@ jobs: set -eu echo "::group::Get source" - PKG=debianutils + PKG=hello pull-lp-source --download-only "$PKG" dpkg-source -x "$PKG"*.dsc pkg-src rm -rf "${PKG}_"* @@ -120,7 +120,7 @@ jobs: # Get package source set -eu - PKG=debianutils + PKG=hello pull-lp-source --download-only "$PKG" dpkg-source -x "$PKG"*.dsc pkg-src rm -rfv "${PKG}_"*.{dsc,debian.}* diff --git a/gh-actions/common/build-debian/action.yaml b/gh-actions/common/build-debian/action.yaml index a984b076..c839edac 100644 --- a/gh-actions/common/build-debian/action.yaml +++ b/gh-actions/common/build-debian/action.yaml @@ -57,11 +57,6 @@ inputs: description: Arguments to pass to lintian, if any. Set to `skip` to skip the lintian check. default: '' - lrc: - required: false - description: Arguments to pass to licenserecon, if any. Set to `skip` to skip the licenserecon check. - default: '' - allow-sudo: description: Allow the build to use sudo. required: false @@ -157,27 +152,6 @@ runs: echo "SOURCE_DIR=${srcdir}" >> "${GITHUB_ENV}" echo "::endgroup::" - - name: Check licenses - if: ${{ inputs.lrc != 'skip' }} - uses: kohlerdominik/docker-run-action@v2.0.0 - with: - # Use ubuntu:devel to have a recent version of licenserecon, because we - # found older versions to report false positives (e.g. GPL-2 vs GPL-2+). - image: ubuntu:devel - volumes: | - ${{ github.workspace }}:${{ github.workspace }} - workdir: ${{ env.SOURCE_DIR }} - shell: bash - run: | - echo "::group::Install licenserecon" - apt-get update - apt-get install -y --no-install-recommends licenserecon - echo "::endgroup::" - - echo "::group::Run licenserecon" - lrc ${{ inputs.lrc }} - echo "::endgroup::" - - name: Prepare source package uses: kohlerdominik/docker-run-action@v2.0.0 with: